Unable to access 2Fast data file after adding a 2FA code

[User-4761]

Describe the bug

The application crashes after adding a new 2FA code, and after reopening, I receive a "Contraseña inválida" error. The program then prompts to change the password, but after entering the same password, the application crashes again. On reopening, instead of displaying the 2FA codes, an error related to 'SecretByteArray' is shown.

Steps to Reproduce

Steps to reproduce the behavior:

1. Given the following environment:

   • Application: 2Fast
   • Application Version: 1.3.5.0
   • Operating System: Windows 11 Home, version 24H2

2. Open the application.

3. Add a new 2FA code entry to the program.

4. The application crashes and closes immediately after adding the new code.

5. Try to reopen the application.

6. When prompted for the password, I enter the correct password, but the application shows the error:
   "Contraseña inválida: La contraseña guardada en esta aplicación no es válida para el archivo de datos. Es posible que haya cambiado la contraseña del archivo de datos utilizando otro dispositivo."
   (Translation: "Invalid password: The password saved in this application is not valid for the data file. It is possible that the data file's password has been changed using another device.")

7. I select the option to "Cambiar la contraseña", enter the same password as the new one, and click "Aceptar." However, the program crashes again.

8. When reopening the application after the crash, I enter the password once more. Instead of displaying the 2FA codes, the following error is shown:
   "Gestión de error: se produjo un error no controlado la última vez que se utilizó la aplicación..."
   (Translation: "Error management: An unhandled error occurred the last time the application was used...")

   Additional error message:
   System.Exception: Exception of type 'System.Exception' was thrown. Error setting value to 'SecretByteArray' on 'Project2FA.Repository.Models.TwoFACodeModel'.

Expected behavior

The application should allow me to change the password and access my 2FA codes without crashing. I expect that the file is properly validated, and the 2FA codes should be displayed correctly after entering the password.

Screenshots

Environment

• App Version(s):
  1.3.5.0

• Windows Version:

  • Windows 10 > May 2020 Update (19041)
  • Windows 11 21H2 Update (22000)
  • Windows 11 22H2/23H2 Update (22621)
  • Windows 11 24H2 Update

Additional context

• The issue started after I added a new 2FA code to the application, causing the program to crash immediately after.
• Upon trying to reopen the application, I was prompted to enter the password but received the "Contraseña inválida" error.
• After attempting to change the password to the same value, the application crashed again.
• When reopening the app again introducing the pasword, instead of showing the 2FA codes, it displayed an error message related to an issue with the SecretByteArray on the TwoFACodeModel, which may suggest a corruption or failure when updating the password.

[User-4761]

By the way, I’d like to highlight that the error:

"System.Exception: Exception of type 'System.Exception' was thrown. Error setting value to 'SecretByteArray' on 'Project2FA.Repository.Models.TwoFACodeModel'"

Appears to be the same issue reported by the user MoscoeMo last month under the issue titled "Crashing for a long time". Due to the limited details provided, I suspect it could be the same bug.

[jp-weber]

Which service is the last one where you have added the second factor?

The log of the application would also be helpful here. The log is also accessible via cmd: https://github.com/2fast-team/2fast/wiki/Open-(error)-log-via-cmd

[User-4761]

My last added service was Facebook, but I don't think it’s the cause. I created another 2FA file after that and had no issues.

I meant to send the application log with my initial report, but I completely forgot,sorry about that! Here it is now.

Log:

2025-03-05 22:55:41 - uptime -10675199.02:48:05.4775808
2025-03-05 22:55:41 - - The system cannot find the file specified. (Exception from HRESULT: 0x80070002)
Log - System.IO.FileNotFoundException: The system cannot find the file specified. (Exception from HRESULT: 0x80070002)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x21
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0x70
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task) + 0x38
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task) + 0x17
at Project2FA.Services.DataService.d__70.MoveNext() + 0xb83

2025-03-07 08:29:44 - uptime -10675199.02:48:05.4775808
2025-03-07 08:29:44 - - The system cannot find the file specified. (Exception from HRESULT: 0x80070002)
Log - System.IO.FileNotFoundException: The system cannot find the file specified. (Exception from HRESULT: 0x80070002)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x21
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0x70
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task) + 0x38
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task) + 0x17
at Project2FA.Services.DataService.d__70.MoveNext() + 0xb83

2025-03-07 09:05:44 - uptime -10675199.02:48:05.4775808
2025-03-07 09:05:44 - - Value cannot be null.
Parameter name: Facebook
Log - System.ArgumentNullException: Value cannot be null.
Parameter name: Facebook
at Project2FA.Services.DataService.d__76.MoveNext() + 0x4d8

2025-03-07 09:05:44 - uptime -10675199.02:48:05.4775808
2025-03-07 09:05:44 - - Value cannot be null.
Parameter name: Facebook

2025-03-07 09:13:23 - System.IO.FileLoadException: The process cannot access the file because it is being used by another process. (Exception from HRESULT: 0x80070020) The file is in use. Please close it before proceeding.
2025-03-07 09:13:23 - uptime -10675199.02:48:05.4775808
2025-03-07 09:13:23 - - Error setting value to 'SecretByteArray' on 'Project2FA.Repository.Models.TwoFACodeModel'.
Log - Newtonsoft.Json.JsonSerializationException: Error setting value to 'SecretByteArray' on 'Project2FA.Repository.Models.TwoFACodeModel'. ---> System.ArgumentNullException: Value cannot be null.
Parameter name: userData
at System.Security.Cryptography.ProtectedData.Protect(Byte[], Byte[], DataProtectionScope) + 0xa4
at Project2FA.Repository.Models.TwoFACodeModel.set_SecretByteArray(Byte[]) + 0x1e
at _$ILCT$.$ILT$ReflectionDynamicInvoke$.InvokeRetVI[T0](Object, IntPtr, InvokeUtils.ArgSetupState&, Boolean) + 0x63
at System.InvokeUtils.CalliIntrinsics.Call(IntPtr, IntPtr, Object, IntPtr, InvokeUtils.ArgSetupState&, Boolean) + 0x55
at System.InvokeUtils.CallDynamicInvokeMethod(Object, IntPtr, Object, IntPtr, IntPtr, Object, Object[], BinderBundle, Boolean, Boolean, Boolean) + 0x160
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x21
at System.Linq.Expressions.Interpreter.ExceptionHelpers.UnwrapAndRethrow(TargetInvocationException) + 0x17
at System.Linq.Expressions.Interpreter.MethodInfoCallInstruction.Run(InterpretedFrame) + 0x1db
at System.Linq.Expressions.Interpreter.Interpreter.Run(InterpretedFrame) + 0x38
at System.Linq.Expressions.Interpreter.LightLambda.RunVoid(Object[]) + 0xbf
at System.Runtime.CompilerServices.ConditionalWeakTable2.CreateValueCallback.Invoke(TKey) + 0x2b
at System.Action2.InvokeObjectArrayThunk(T1, T2) + 0x5f
at Newtonsoft.Json.Serialization.ExpressionValueProvider.SetValue(Object, Object) + 0x94

--- End of inner exception stack trace ---
at Newtonsoft.Json.Serialization.ExpressionValueProvider.SetValue(Object, Object) + 0x115
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.SetPropertyValue(JsonProperty, JsonConverter, JsonContainerContract, JsonProperty, JsonReader, Object) + 0x1c0
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object, JsonReader, JsonObjectContract, JsonProperty, String) + 0x6cd
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader, Type, JsonContract, JsonProperty, JsonContainerContract, JsonProperty, Object) + 0x32a
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader, Type, JsonContract, JsonProperty, JsonContainerContract, JsonProperty, Object) + 0xbc
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateList(IList, JsonReader, JsonArrayContract, JsonProperty, String) + 0x3de
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateList(JsonReader, Type, JsonContract, JsonProperty, Object, String) + 0x110
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader, Type, JsonContract, JsonProperty, JsonContainerContract, JsonProperty, Object) + 0xf5
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.SetPropertyValue(JsonProperty, JsonConverter, JsonContainerContract, JsonProperty, JsonReader, Object) + 0x16d
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object, JsonReader, JsonObjectContract, JsonProperty, String) + 0x6cd
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader, Type, JsonContract, JsonProperty, JsonContainerContract, JsonProperty, Object) + 0x32a
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader, Type, JsonContract, JsonProperty, JsonContainerContract, JsonProperty, Object) + 0xbc
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader, Type, Boolean) + 0x239
at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader, Type) + 0xf3
at Newtonsoft.Json.JsonConvert.DeserializeObject(String, Type, JsonSerializerSettings) + 0xd6
at Newtonsoft.Json.JsonConvert.DeserializeObjectT + 0x32
at Project2FA.Core.Services.JSON.NewtonsoftJSONService.DeserializeT + 0x42
at Project2FA.Services.DataService.d__70.MoveNext() + 0x5b4

By the way, I just want to say that overall I’m really satisfied with the program. Even though this issue popped up, luckily I had a backup file, so I didn’t lose anything. Keep up the great work!