Skip to content

Commit 6033249

Browse files
committed
Temporarily disable signing until we can figure out a new way
1 parent 82e4fdc commit 6033249

File tree

3 files changed

+31
-30
lines changed

3 files changed

+31
-30
lines changed

.github/workflows/build.yml

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -148,19 +148,20 @@ jobs:
148148
if: 'false' # temporarily disabled
149149
run: buildcache -s
150150

151-
- name: Import signing certificate
152-
uses: devbotsxyz/xcode-import-certificate@master
153-
with:
154-
certificate-data: ${{secrets.MACOS_CERTIFICATE_DATA}}
155-
certificate-passphrase: ${{secrets.MACOS_CERTIFICATE_PASSWORD}}
156-
keychain-password: ${{secrets.MACOS_KEYCHAIN_PASSWORD}}
151+
#- name: Import signing certificate
152+
# if: 'false' # temporarily disabled
153+
#uses: devbotsxyz/xcode-import-certificate@master
154+
#with:
155+
# certificate-data: ${{secrets.MACOS_CERTIFICATE_DATA}}
156+
# certificate-passphrase: ${{secrets.MACOS_CERTIFICATE_PASSWORD}}
157+
# keychain-password: ${{secrets.MACOS_KEYCHAIN_PASSWORD}}
157158

158159
- name: Deploy & codesign application
159-
env:
160-
ASC_USERNAME: ${{secrets.MACOS_ASC_USERNAME}}
161-
ASC_PASSWORD: ${{secrets.MACOS_ASC_PASSWORD}}
162-
ASC_TEAM_ID: ${{secrets.MACOS_ASC_TEAM_ID}}
163-
CODESIGN_IDENT: ${{secrets.MACOS_CODESIGN_IDENT}}
160+
#env:
161+
#ASC_USERNAME: ${{secrets.MACOS_ASC_USERNAME}}
162+
#ASC_PASSWORD: ${{secrets.MACOS_ASC_PASSWORD}}
163+
#ASC_TEAM_ID: ${{secrets.MACOS_ASC_TEAM_ID}}
164+
#CODESIGN_IDENT: ${{secrets.MACOS_CODESIGN_IDENT}}
164165
run: ci/build-dmg.sh
165166

166167
- name: Upload artifacts

.github/workflows/release.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -168,19 +168,19 @@ jobs:
168168
SENTRY_URL: ${{secrets.SENTRY_URL}}
169169
run: ci/upload-debug-macos.sh
170170

171-
- name: Import signing certificate
172-
uses: devbotsxyz/xcode-import-certificate@master
173-
with:
174-
certificate-data: ${{ secrets.MACOS_CERTIFICATE_DATA }}
175-
certificate-passphrase: ${{ secrets.MACOS_CERTIFICATE_PASSWORD }}
176-
keychain-password: ${{ secrets.MACOS_KEYCHAIN_PASSWORD }}
171+
#- name: Import signing certificate
172+
# uses: devbotsxyz/xcode-import-certificate@master
173+
# with:
174+
# certificate-data: ${{ secrets.MACOS_CERTIFICATE_DATA }}
175+
# certificate-passphrase: ${{ secrets.MACOS_CERTIFICATE_PASSWORD }}
176+
# keychain-password: ${{ secrets.MACOS_KEYCHAIN_PASSWORD }}
177177

178178
- name: Deploy & codesign application
179-
env:
180-
ASC_USERNAME: ${{secrets.MACOS_ASC_USERNAME}}
181-
ASC_PASSWORD: ${{secrets.MACOS_ASC_PASSWORD}}
182-
ASC_TEAM_ID: ${{secrets.MACOS_ASC_TEAM_ID}}
183-
CODESIGN_IDENT: ${{secrets.MACOS_CODESIGN_IDENT}}
179+
#env:
180+
# ASC_USERNAME: ${{secrets.MACOS_ASC_USERNAME}}
181+
# ASC_PASSWORD: ${{secrets.MACOS_ASC_PASSWORD}}
182+
# ASC_TEAM_ID: ${{secrets.MACOS_ASC_TEAM_ID}}
183+
# CODESIGN_IDENT: ${{secrets.MACOS_CODESIGN_IDENT}}
184184
run: ci/build-dmg.sh
185185

186186
- name: Upload artifacts

ci/build-dmg.sh

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
#!/bin/bash -ex
22
cd build/install
3-
for i in Metaforce crashpad_handler; do
4-
if [ -x "Metaforce.app/Contents/MacOS/$i" ]; then
5-
codesign --timestamp --options runtime -s "$CODESIGN_IDENT" "Metaforce.app/Contents/MacOS/$i"
6-
fi
7-
done
8-
create-dmg Metaforce.app --identity="$CODESIGN_IDENT" .
9-
xcrun altool -t osx -f *.dmg --primary-bundle-id com.axiodl.Metaforce \
10-
--notarize-app -u "$ASC_USERNAME" -p "$ASC_PASSWORD" --team-id "$ASC_TEAM_ID"
3+
#for i in Metaforce crashpad_handler; do
4+
# if [ -x "Metaforce.app/Contents/MacOS/$i" ]; then
5+
# codesign --timestamp --options runtime -s "$CODESIGN_IDENT" "Metaforce.app/Contents/MacOS/$i"
6+
# fi
7+
#done
8+
create-dmg Metaforce.app . #--identity="$CODESIGN_IDENT" .
9+
#xcrun altool -t osx -f *.dmg --primary-bundle-id com.axiodl.Metaforce \
10+
# --notarize-app -u "$ASC_USERNAME" -p "$ASC_PASSWORD" --team-id "$ASC_TEAM_ID"

0 commit comments

Comments
 (0)