Fixed heading IDs and anchor generation logic. Fixed default value for "enableConsole" option in operation details. (#359)

azaslonov · web-flow · commit 7e4add725683 · 2019-12-06T12:59:12.000-08:00
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -59,11 +59,11 @@
         "webpack-merge": "^4.2.2"
     },
     "dependencies": {
-        "@paperbits/azure": "0.1.181",
-        "@paperbits/common": "0.1.181",
-        "@paperbits/core": "0.1.181",
-        "@paperbits/prosemirror": "0.1.181",
-        "@paperbits/styles": "0.1.181",
+        "@paperbits/azure": "0.1.183",
+        "@paperbits/common": "0.1.183",
+        "@paperbits/core": "0.1.183",
+        "@paperbits/prosemirror": "0.1.183",
+        "@paperbits/styles": "0.1.183",
         "@webcomponents/webcomponentsjs": "^2.4.0",
         "adal-vanilla": "^1.0.18",
         "applicationinsights-js": "^1.0.20",
diff --git a/src/components/operations/operation-details/operationDetailsModelBinder.ts b/src/components/operations/operation-details/operationDetailsModelBinder.ts
@@ -14,7 +14,7 @@ export class OperationDetailsModelBinder implements IModelBinder<OperationDetail
 
     public async contractToModel(contract: OperationDetailsContract): Promise<OperationDetailsModel> {
         const model = new OperationDetailsModel();
-        model.enableConsole = contract.enableConsole === true;
+        model.enableConsole = contract.enableConsole === true || contract.enableConsole === undefined;
 
         return model;
     }
diff --git a/src/persistence/mapiObjectStorage.ts b/src/persistence/mapiObjectStorage.ts
@@ -346,7 +346,7 @@ export class MapiObjectStorage implements IObjectStorage {
     public convertPaperbitsContractToArmContract(contract: any, isLocalized: boolean = false): any {
         let converted;
 
-        if (!contract) {
+        if (contract === null || contract === undefined) { // here we expect "false" as a value too
             return null;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ export class OperationDetailsModelBinder implements IModelBinder<OperationDetail`
`14`	`14`
`15`	`15`	`public async contractToModel(contract: OperationDetailsContract): Promise<OperationDetailsModel> {`
`16`	`16`	`const model = new OperationDetailsModel();`
`17`		`- model.enableConsole = contract.enableConsole === true;`
	`17`	`+ model.enableConsole = contract.enableConsole === true \|\| contract.enableConsole === undefined;`
`18`	`18`
`19`	`19`	`return model;`
`20`	`20`	`}`
Original file line number	Diff line number	Diff line change
`@@ -346,7 +346,7 @@ export class MapiObjectStorage implements IObjectStorage {`
`346`	`346`	`public convertPaperbitsContractToArmContract(contract: any, isLocalized: boolean = false): any {`
`347`	`347`	`let converted;`
`348`	`348`
`349`		`- if (!contract) {`
	`349`	`+ if (contract === null \|\| contract === undefined) { // here we expect "false" as a value too`
`350`	`350`	`return null;`
`351`	`351`	`}`
`352`	`352`