BUG: Fix out-of-bounds array access in RequireMinNumNeighbors Filter

Signed-off-by: Michael Jackson <[email protected]>

Author: imikejackson

src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/RequireMinNumNeighbors.cpp

@@ -17,18 +17,23 @@ Result<> CopyTupleFromArray(DataStructure& dataStructure, const DataPath& dataAr
   auto arraySize = voxelArray->getSize();
   for(const auto& featureIdIndex : badFeatureIdIndexes)
   {
-    int32 featureName = featureIds.getValue(featureIdIndex);
-    int32 neighbor = neighbors[featureIdIndex];
+    const int32 featureName = featureIds.getValue(featureIdIndex);
+    const int32 neighbor = neighbors[featureIdIndex];
+
     if((neighbor >= arraySize || featureIdIndex >= arraySize) && (featureName < 0 && neighbor >= 0 && featureIds.getValue(neighbor) >= 0))
     {
       const std::string message =
           fmt::format("Out of range: While trying to copy a tuple from index {} to index {}\n  Array Name: {}\n  Num. Tuples: {}", neighbor, featureIdIndex, dataArrayPath.toString(), arraySize);
       mesgHandler(nx::core::IFilter::Message{nx::core::IFilter::Message::Type::Info, message});
       return MakeErrorResult(-55568, message);
     }
-    if(int32 fId = featureIds.getValue(neighbor); featureName < 0 && neighbor >= 0 && fId >= 0)
+
+    if(featureName < 0 && neighbor >= 0)
     {
-      voxelArray->copyTuple(neighbor, featureIdIndex);
+      if(const int32 fId = featureIds.getValue(neighbor); fId >= 0)
+      {
+        voxelArray->copyTuple(neighbor, featureIdIndex);
+      }
     }
   }
   return {};