Skip to content

Commit c835f8f

Browse files
committed
Fix Python examples and pipelines.
Signed-off-by: Joey Kleingers <[email protected]>
1 parent adb8e4a commit c835f8f

File tree

7 files changed

+26
-16
lines changed

7 files changed

+26
-16
lines changed

src/Plugins/SimplnxCore/wrapping/python/simplnxpy.cpp

Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@
7979
#include <simplnx/Parameters/ReadHDF5DatasetParameter.hpp>
8080
#include <simplnx/Parameters/StringParameter.hpp>
8181
#include <simplnx/Parameters/VectorParameter.hpp>
82+
#include <simplnx/Parameters/util/ReadCSVData.hpp>
8283
#include <simplnx/Pipeline/AbstractPipelineNode.hpp>
8384
#include <simplnx/Pipeline/Pipeline.hpp>
8485
#include <simplnx/Pipeline/PipelineFilter.hpp>
@@ -497,6 +498,20 @@ PYBIND11_MODULE(simplnx, mod)
497498
dataType.value("float64", DataType::float64);
498499
dataType.value("boolean", DataType::boolean);
499500

501+
py::enum_<CSVType> csvType(mod, "CSVType");
502+
csvType.value("int8", CSVType::int8);
503+
csvType.value("uint8", CSVType::uint8);
504+
csvType.value("int16", CSVType::int16);
505+
csvType.value("uint16", CSVType::uint16);
506+
csvType.value("int32", CSVType::int32);
507+
csvType.value("uint32", CSVType::uint32);
508+
csvType.value("int64", CSVType::int64);
509+
csvType.value("uint64", CSVType::uint64);
510+
csvType.value("float32", CSVType::float32);
511+
csvType.value("float64", CSVType::float64);
512+
csvType.value("boolean", CSVType::boolean);
513+
csvType.value("string", CSVType::string);
514+
500515
mod.def(
501516
"convert_np_dtype_to_datatype",
502517
[](const py::dtype& dtype) {
@@ -678,8 +693,7 @@ PYBIND11_MODULE(simplnx, mod)
678693
parameters.def("insert_linkable_parameter", &PyInsertLinkableParameter<ChoicesParameter>);
679694
parameters.def("link_parameters", [](Parameters& self, std::string groupKey, std::string childKey, BoolParameter::ValueType value) { self.linkParameters(groupKey, childKey, value); });
680695
parameters.def("link_parameters", [](Parameters& self, std::string groupKey, std::string childKey, ChoicesParameter::ValueType value) { self.linkParameters(groupKey, childKey, value); });
681-
parameters.def(
682-
"__getitem__", [](Parameters& self, std::string_view key) { return self.at(key).get(); }, py::return_value_policy::reference_internal);
696+
parameters.def("__getitem__", [](Parameters& self, std::string_view key) { return self.at(key).get(); }, py::return_value_policy::reference_internal);
683697

684698
py::class_<IArrayThreshold, std::shared_ptr<IArrayThreshold>> iArrayThreshold(mod, "IArrayThreshold");
685699

@@ -1539,12 +1553,10 @@ PYBIND11_MODULE(simplnx, mod)
15391553
"path"_a);
15401554
pipeline.def_property("name", &Pipeline::getName, &Pipeline::setName);
15411555
pipeline.def("execute", &ExecutePipeline);
1542-
pipeline.def(
1543-
"__getitem__", [](Pipeline& self, Pipeline::index_type index) { return self.at(index); }, py::return_value_policy::reference_internal);
1556+
pipeline.def("__getitem__", [](Pipeline& self, Pipeline::index_type index) { return self.at(index); }, py::return_value_policy::reference_internal);
15441557
pipeline.def("__len__", &Pipeline::size);
15451558
pipeline.def("size", &Pipeline::size);
1546-
pipeline.def(
1547-
"__iter__", [](Pipeline& self) { return py::make_iterator(self.begin(), self.end()); }, py::keep_alive<0, 1>());
1559+
pipeline.def("__iter__", [](Pipeline& self) { return py::make_iterator(self.begin(), self.end()); }, py::keep_alive<0, 1>());
15481560
pipeline.def(
15491561
"insert",
15501562
[internals](Pipeline& self, Pipeline::index_type index, const IFilter& filter, const py::dict& args) {
@@ -1558,10 +1570,8 @@ PYBIND11_MODULE(simplnx, mod)
15581570
pipeline.def("remove", &Pipeline::removeAt, "index"_a);
15591571

15601572
pipelineFilter.def("get_args", [internals](PipelineFilter& self) { return ConvertArgsToDict(*internals, self.getParameters(), self.getArguments()); });
1561-
pipelineFilter.def(
1562-
"set_args", [internals](PipelineFilter& self, py::dict& args) { self.setArguments(ConvertDictToArgs(*internals, self.getParameters(), args)); }, "args"_a);
1563-
pipelineFilter.def(
1564-
"get_filter", [](PipelineFilter& self) { return self.getFilter(); }, py::return_value_policy::reference_internal);
1573+
pipelineFilter.def("set_args", [internals](PipelineFilter& self, py::dict& args) { self.setArguments(ConvertDictToArgs(*internals, self.getParameters(), args)); }, "args"_a);
1574+
pipelineFilter.def("get_filter", [](PipelineFilter& self) { return self.getFilter(); }, py::return_value_policy::reference_internal);
15651575
pipelineFilter.def(
15661576
"name",
15671577
[](const PipelineFilter& self) {

wrapping/python/docs/source/Developer_API.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1369,7 +1369,7 @@ General Parameters
13691369
read_csv_data.start_import_row = 2
13701370
read_csv_data.delimiters = [',']
13711371
read_csv_data.custom_headers = []
1372-
read_csv_data.column_data_types = [nx.DataType.float32,nx.DataType.float32,nx.DataType.float32,nx.DataType.float32,nx.DataType.float32,nx.DataType.float32,nx.DataType.int32]
1372+
read_csv_data.column_data_types = [nx.CSVType.float32,nx.CSVType.float32,nx.CSVType.float32,nx.CSVType.float32,nx.CSVType.float32,nx.CSVType.float32,nx.CSVType.int32]
13731373
read_csv_data.skipped_array_mask = [False,False,False,False,False,False,False]
13741374
read_csv_data.tuple_dims = [37989]
13751375
read_csv_data.headers_line = 1

wrapping/python/docs/source/User_API.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -694,7 +694,7 @@ General Parameters
694694
read_csv_data.start_import_row = 2
695695
read_csv_data.delimiters = [',']
696696
read_csv_data.custom_headers = []
697-
read_csv_data.column_data_types = [nx.DataType.float32,nx.DataType.float32,nx.DataType.float32,nx.DataType.float32,nx.DataType.float32,nx.DataType.float32,nx.DataType.int32 ]
697+
read_csv_data.column_data_types = [nx.CSVType.float32,nx.CSVType.float32,nx.CSVType.float32,nx.CSVType.float32,nx.CSVType.float32,nx.CSVType.float32,nx.CSVType.int32 ]
698698
read_csv_data.skipped_array_mask = [False,False,False,False,False,False,False ]
699699
read_csv_data.tuple_dims = [37989]
700700
read_csv_data.headers_line = 1

wrapping/python/examples/pipelines/Simplnx/Import_ASCII.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
read_csv_data.start_import_row = 1
4848
read_csv_data.delimiters = [',']
4949
read_csv_data.custom_headers = ['phi1', 'Phi', 'phi2']
50-
read_csv_data.column_data_types = [nx.DataType.float32, nx.DataType.float32, nx.DataType.float32]
50+
read_csv_data.column_data_types = [nx.CSVType.float32, nx.CSVType.float32, nx.CSVType.float32]
5151
read_csv_data.skipped_array_mask = [False, False, False]
5252
read_csv_data.tuple_dims = [480_001]
5353
read_csv_data.headers_line = 1

wrapping/python/examples/pipelines/Simplnx/ResampleRectGridToImageGeom.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
read_csv_data.start_import_row = 2
1919
read_csv_data.delimiters = [',']
2020
read_csv_data.custom_headers = ['x', 'y', 'z']
21-
read_csv_data.column_data_types = [nx.DataType.float32, nx.DataType.float32, nx.DataType.float32]
21+
read_csv_data.column_data_types = [nx.CSVType.float32, nx.CSVType.float32, nx.CSVType.float32]
2222
read_csv_data.skipped_array_mask = [False, False, False]
2323
read_csv_data.tuple_dims = [14]
2424
read_csv_data.headers_line = 1

wrapping/python/examples/scripts/read_csv_file.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
read_csv_data.start_import_row = 2
5656
read_csv_data.delimiters = [',']
5757
read_csv_data.custom_headers = []
58-
read_csv_data.column_data_types = [nx.DataType.float32,nx.DataType.float32,nx.DataType.float32,nx.DataType.float32,nx.DataType.float32,nx.DataType.float32,nx.DataType.int32 ]
58+
read_csv_data.column_data_types = [nx.CSVType.float32,nx.CSVType.float32,nx.CSVType.float32,nx.CSVType.float32,nx.CSVType.float32,nx.CSVType.float32,nx.CSVType.int32 ]
5959
read_csv_data.skipped_array_mask = [False,False,False,False,False,False,False ]
6060
read_csv_data.tuple_dims = [37989]
6161
read_csv_data.headers_line = 1

wrapping/python/plugins/ExamplePlugin/src/ExamplePlugin/ExampleFilter1.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ def parameters(self) -> nx.Parameters:
153153
read_csv_data.start_import_row = 2
154154
read_csv_data.delimiters = [',']
155155
read_csv_data.custom_headers = []
156-
read_csv_data.column_data_types = [nx.DataType.float32,nx.DataType.float32,nx.DataType.float32,nx.DataType.float32,nx.DataType.float32,nx.DataType.float32,nx.DataType.int32]
156+
read_csv_data.column_data_types = [nx.CSVType.float32,nx.CSVType.float32,nx.CSVType.float32,nx.CSVType.float32,nx.CSVType.float32,nx.CSVType.float32,nx.CSVType.int32]
157157
read_csv_data.skipped_array_mask = [False,False,False,False,False,False,False]
158158
read_csv_data.tuple_dims = [37989]
159159
read_csv_data.headers_line = 1

0 commit comments

Comments
 (0)