Skip to content

Extract main-nav to separate file/component #11959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eszkadev opened this issue May 16, 2025 · 0 comments
Open

Extract main-nav to separate file/component #11959

eszkadev opened this issue May 16, 2025 · 0 comments

Comments

@eszkadev
Copy link
Contributor

eszkadev commented May 16, 2025

This is an Easy Hack.
Potential mentors: @eszkadev @Darshan-upadhyay1110

Detailed description and rationale

We have couple of really big files which would be good to shorten (eg. Control.UIManager.ts) and clean from legacy code - jQuery.

Please check .main-nav element. It has some handlers attached and also class toggles in various places.
main-nav code. Would be good to bundle them together in a single place.

Tasks:

  • create separate TS file -> browser/src/control/Control.MenuAndTitleBar.ts
  • put there all related code to that element (.main-nav) converted to TypeScript
  • remove jQuery usage
  • use it's methods in external code (Control.UIManager.ts, Control.Notebookbar.js, Control.Toolbar.js)

Be inspired by other TS files inside browser/src/control/Control.* files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant