Skip to content

[C-1048] Members: Search members with associated email #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tchiotludo opened this issue Mar 30, 2023 · 13 comments · May be fixed by #1478
Open

[C-1048] Members: Search members with associated email #703

tchiotludo opened this issue Mar 30, 2023 · 13 comments · May be fixed by #1478
Labels
Contributor Created by Linear-GitHub Sync good first issue 🥂 Good for newcomers help wanted 🙏 help from the community is highly appreciated High priority Created by Linear-GitHub Sync Improvement Created by Linear-GitHub Sync linear

Comments

@tchiotludo
Copy link

tchiotludo commented Mar 30, 2023

What problem are you trying to solve?

I want to be able to find all members that have at least one email.

The same than identities for email:
image

I also need to be able to search for a substring on the email (mostly the domain name of the email)

What's your suggested solution?

No response

Examples (if relevant)

No response

Is anything blocking this from being implemented? (if relevant)

No response

Definition of Done

No response

C-1048

@jonathimer
Copy link
Contributor

Thanks for that input. And yes, I agree that we should have this filter capability.

We will see if we can prioritize it.

@jonathimer jonathimer added Improvement Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync linear labels Mar 30, 2023
@jonathimer jonathimer changed the title Members: Search members with associated email [C-1048] Members: Search members with associated email Mar 30, 2023
@joanreyero joanreyero added the good first issue 🥂 Good for newcomers label May 9, 2023
@fork-boy
Copy link

@jonathimer, @joanreyero
i can work on this one. just a small doubt
how it should look in the UI, just like filters options drop down should have an email option and then clicking on it opens a search bar to filter out on basis of emails sub string user enters?

@jonathimer
Copy link
Contributor

Awesome! Looping in @nunoeufrasio who is the product designer for this product

I think we should simply add a string search filter called "Emails".
Additionally, we could add Email as option to the multi-select filter "Identities". This would allow users to filter by all members that have an email associated to their profile.

@jonathimer jonathimer added the help wanted 🙏 help from the community is highly appreciated label May 18, 2023
@nunoeufrasio
Copy link
Contributor

Agree with @jonathimer on adding email to identities filter, in fact we treat it as an identity.

As per searching for email (substrings), I would simply allow users to query them via the search bar…we already let users find members typing the full email/string.

We can tweak the search bar placeholder so its clear ⬇️
Screenshot 2023-05-19 at 04 46 36

@joanagmaia
Copy link
Contributor

Hey 👋
Sorry for the late reply @agentraghav! Just checked with @anilb0stanci and at the moment backend does not support this issue's requirements. To be able to search for an email without a full match and include email in the Identities filter, this issue must be addressed first

@tchiotludo
Copy link
Author

any update on a release date?
I've some members on slack that changed their nickname, without email search I could find them on crowd.dev because :

  • the new nickname is not indexed on crowd.dev
  • email is not searchable (the only link I could have on this kind of members)

THanks

@jonathimer
Copy link
Contributor

Hey @tchiotludo! The issue is currently being tackled internally. ETA is 1-2 weeks.

@jonathimer jonathimer added High priority Created by Linear-GitHub Sync and removed Medium priority Created by Linear-GitHub Sync labels Jul 6, 2023
@jonathimer jonathimer assigned skwowet and unassigned fork-boy Jul 13, 2023
@jonathimer jonathimer modified the milestones: v.41, v.42 Aug 28, 2023
@peoray
Copy link
Contributor

peoray commented Sep 6, 2023

@jonathimer @yeganathan18 is this still internally implemented? I can see that the BE ticket @joanagmaia mentioned has been merged

@jonathimer jonathimer added the Contributor Created by Linear-GitHub Sync label Sep 6, 2023
@jonathimer jonathimer modified the milestones: v.42, v.43 Sep 7, 2023
@peoray
Copy link
Contributor

peoray commented Sep 11, 2023

@yeganathan18 @joanagmaia, any update on this :)

@joanagmaia
Copy link
Contributor

Hey @peoray it's partially done. So we are now able to search by email in the search bar, but as mentioned in the issue description, it would also be needed to add the Email option to the Identities filter, so that user is able to filter members that have at least one email

@peoray
Copy link
Contributor

peoray commented Sep 12, 2023

@joanagmaia Identities filer option is coming from the integration. Email is not an integration, any clue how to add it such that the query would be successful?
I added it manually to the array but that did not work

@peoray peoray linked a pull request Sep 12, 2023 that will close this issue
5 tasks
@jonathimer jonathimer modified the milestones: v.43, v.44 Sep 17, 2023
@joanagmaia
Copy link
Contributor

Hey @peoray, sorry I missed this!
You are very right, emails work differently from other identities.
So in frontend/src/modules/member/config/filters/identities/config.ts you will need to refactor apiFilterRenderer so that email is treated differently.
For email specifically, we will probably want something like

email: {
   ne: null
}

Let me know if this helps

@peoray
Copy link
Contributor

peoray commented Sep 26, 2023

@joanagmaia how can I make sure Email is added as one of the select options?
I'm getting an unknown field operator error
Unknown field or operator: email!

The PR has been updated to reflect the new changes

@jonathimer jonathimer modified the milestone: v.56 Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor Created by Linear-GitHub Sync good first issue 🥂 Good for newcomers help wanted 🙏 help from the community is highly appreciated High priority Created by Linear-GitHub Sync Improvement Created by Linear-GitHub Sync linear
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

8 participants