Skip to content

Prepare endpoint to connect a new github integration over Nango #2939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
themarolt opened this issue Mar 18, 2025 — with Linear · 0 comments
Open

Prepare endpoint to connect a new github integration over Nango #2939

themarolt opened this issue Mar 18, 2025 — with Linear · 0 comments
Assignees
Labels
Backend 🛠️ Integrations Created by Linear-GitHub Sync

Comments

Copy link
Contributor

In the database we still want just one platform = github so the distinction has to be in the settings and it has to be set when connecting the integration.

We need a list of connections that are to be used with token rotation (stored in the db - new table githubTokenRotations) which are then passed as metadata to the nango connection being made.

There is also a distinction here between gerrit and github where we will have just one integrations row and multiple nango connections - 1 per repository. This means that the nango connections have to be mapped to 1 integrations row so in the settings column besides the repos we would also need mapping between a repo and a nango connection id.

Because of this change there will also be slight change in nango-webhook-api and nango-worker because they are assuming 1 integrations row = 1 nango connection which won't be the case here.

@themarolt themarolt added the Integrations Created by Linear-GitHub Sync label Mar 18, 2025 — with Linear
@themarolt themarolt self-assigned this Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend 🛠️ Integrations Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

1 participant