Add "Mode" Method Support for rueidis.Client Integration #3347
korECM
started this conversation in
Feature Request
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Package Name
redis/rueidis
Package Version(s)
v1.0.56
Describe the feature you'd like
I would like the dd-trace-go integration for rueidis to support the updated
rueidis.Client
interface, which now includes theMode()
method. This would enable seamless instrumentation with the latest version of rueidis.Is your feature request related to a problem?
Yes, it is. Currently, dd-trace-go's integration for rueidis fails to compile because the internal client does not implement the Mode() method required by the updated rueidis.Client interface. This prevents users from using the latest version of rueidis with dd-trace-go.
Describe alternatives you've considered
One workaround is to continue using an older version of rueidis before the addition of the Mode() method. However, this limits access to newer features and improvements in rueidis. Another alternative involves forking dd-trace-go to add the missing interface method, but this is not ideal for maintaining compatibility.
Additional context
The issue originates from the changes introduced in redis/rueidis#794. Incorporating support for the Mode() method in dd-trace-go's rueidis integration would resolve the interface compatibility issues and allow users to take full advantage of the latest updates in rueidis.
Beta Was this translation helpful? Give feedback.
All reactions