Skip to content

[FEATURE]: Improve inferred service naming for redis/ioredis #5615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pmaznov opened this issue Apr 25, 2025 · 0 comments
Open

[FEATURE]: Improve inferred service naming for redis/ioredis #5615

pmaznov opened this issue Apr 25, 2025 · 0 comments

Comments

@pmaznov
Copy link

pmaznov commented Apr 25, 2025

Package Name

No response

Package Version(s)

5.10.0

Describe the feature you'd like

Hi everyone,

We are using this library to trace our NodeJS service request, and noticed that inferred redis name on span is resolved to db.name: "0" which looks more like a placeholder - here

here is the screenshot of one of the ioredis spans:

Image

Maybe it could be more interesting to reuse same approach as redis integration in PHP library and use peer.hostname instead.

Image

Is your feature request related to a problem?

it's not a huge problem, but rather an inconvenience when on dependency map you can't clearly see which redis instance it is and we see just a placeholder instead

Describe alternatives you've considered

Alternative would probably be to use hook and try to intercept redis span and change service name which may be probably treated as override

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant