Skip to content

[FEATURE]: DD Test Impact Analysis to not override coverageReporters in jest config #5666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rafal-pomocnik-captivateiq opened this issue May 6, 2025 · 4 comments
Assignees

Comments

@rafal-pomocnik-captivateiq
Copy link

rafal-pomocnik-captivateiq commented May 6, 2025

Package Name

dd-trace

Package Version(s)

v4.55.0 (but valid also for v5/latest)

Describe the feature you'd like

https://github.com/DataDog/dd-trace-js/blob/v4.55.0/packages/datadog-instrumentations/src/jest.js#L745

Wanted to enable DD Test Impact Analysis feature over jest tests as we had integration with DD Test Optimisation feature already going, but still get code coverage reports to work despite some tests were skipped, as even partial code coverage could be important for further calculations made over it and some custom reporting is happening right after it.

Would be great if coverage reporters setting were not altered, or if it would be possible to skip this override via some env var set.

Is your feature request related to a problem?

No response

Describe alternatives you've considered

For now went with applying patch over dd-trace package that comments out this line which solves it for me

Additional context

No response

@Mariovido
Copy link
Contributor

Thanks for the suggestion, it’s a great idea and we’ll keep it in mind for future improvements. Right now, we don’t have the bandwidth to take it on.

Also, please note that the 4.x tracer line is no longer supported, so any future updates will only be available in the latest versions.

@rafal-pomocnik-captivateiq
Copy link
Author

Thanks for answer @Mariovido - yes, we are aware of 4.x not being supported anymore and surely will look into moving to v5/latest 👌

For now we can override it via having a patch over this single line that is problematic for us so overall we're good, was just curious if this could be easy enough to resolve via one more env var like DD_CIVISIBILITY_ITR_CODE_COVERAGE_ENABLED or something of that sort as a smaller effort to give more control over this particular line overriding coverage jest settings

@Mariovido
Copy link
Contributor

@rafal-pomocnik-captivateiq. We can consider implementing something like the new environment variable you mentioned. However, we currently don’t have the bandwidth to work on it. That said, I’ll keep you updated here as soon as there’s any progress. Thank you again for your request!

@rafal-pomocnik-captivateiq
Copy link
Author

Sure, thank you too @Mariovido!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants