Skip to content

[FEATURE]: Support character escaping in DD_SERVICE_MAPPING #13263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
morganrowse-olympus opened this issue Apr 24, 2025 · 1 comment
Open

Comments

@morganrowse-olympus
Copy link

morganrowse-olympus commented Apr 24, 2025

Package Name

No response

Package Version(s)

No response

Describe the goal of the feature

Currently it is impossible to perform service mapping with services with : in them ie

Working as expected
DD_SERVICE_MAPPING=oldservice:newservice

Not working as expected
DD_SERVICE_MAPPING=https://old-service.com:newservice
DD_SERVICE_MAPPING=oldservice:https://new-service.com

Ideally the following would work as expected
DD_SERVICE_MAPPING=https\://old-service.com:newservice
DD_SERVICE_MAPPING=oldservice:https\://new-service.com

The Reason for this is as it splits on the first :

It would be great if we could escape : and , in the DD_SERVICE_MAPPING vars.

key, val = tag.split(":", 1)

Is your feature request related to a problem?

No response

Describe alternatives you've considered

No response

Additional context

No response

@quinna-h
Copy link
Contributor

Hi @morganrowse-olympus ,

Thanks for opening this feature request!

The team was wondering how you're setting the service name with the format https://old-service.com/ (i.e. are you using DD_SERVICE)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants