Skip to content

[BUG]: TypeError can't concat str to bytes For postgres.query span. #13403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martinuncountable opened this issue May 13, 2025 · 0 comments
Open
Labels

Comments

@martinuncountable
Copy link

Tracer Version(s)

3.7.0

Python Version(s)

Python 3.12.3

Pip Version(s)

pip 25.1

Bug Report

ddtrace/internal/_encoding.pyx in ddtrace.internal._encoding.truncate_string at line 101

We did not see this error: TypeError can't concat str to bytes until upgrading from 3.6.0 to 3.7.0.

Reproduction Code

I lowered the limits in trace/_limits.py.

We use sqlalchemy that creates a postgres.query span where span.resource = b'....' (the resource is bytes). We now hit this branch: 5aa32d1#diff-23840af0f4cae717d33e76ce1d0f4766fcc2e1f46a52e9716f6632d984ddfb4cR28-R99
Which causes the exception above.

Error Logs

  File "ddtrace/internal/_encoding.pyx", line 1000, in ddtrace.internal._encoding.MsgpackEncoderV05.put
  File "ddtrace/internal/_encoding.pyx", line 1001, in ddtrace.internal._encoding.MsgpackEncoderV05.put
  File "ddtrace/internal/_encoding.pyx", line 1007, in ddtrace.internal._encoding.MsgpackEncoderV05.put
  File "ddtrace/internal/_encoding.pyx", line 1004, in ddtrace.internal._encoding.MsgpackEncoderV05.put
  File "ddtrace/internal/_encoding.pyx", line 518, in ddtrace.internal._encoding.MsgpackEncoderBase.put
  File "ddtrace/internal/_encoding.pyx", line 522, in ddtrace.internal._encoding.MsgpackEncoderBase.put
  File "ddtrace/internal/_encoding.pyx", line 545, in ddtrace.internal._encoding.MsgpackEncoderBase.put
  File "ddtrace/internal/_encoding.pyx", line 526, in ddtrace.internal._encoding.MsgpackEncoderBase.put
  File "ddtrace/internal/_encoding.pyx", line 510, in ddtrace.internal._encoding.MsgpackEncoderBase._pack_trace
RuntimeError: failed to pack span: <Span(id=2038801128094967499,trace_id=138423436045302291278799403029836899937,parent_id=4589801555931958614,name=postgres.query)>. Exception: can't concat str to bytes

Libraries in Use

sqlalchemy==2.0.35
psycopg2==2.9.10

Operating System

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant