Skip to content

WIP: DD_TRACE_DEBUG logs to info #14053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: 3.10
Choose a base branch
from
Draft

Conversation

rachelyangdog
Copy link
Contributor

DO NOT MERGE FOR TESTING PURPOSES

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@rachelyangdog rachelyangdog requested review from a team as code owners July 17, 2025 21:01
@rachelyangdog rachelyangdog marked this pull request as draft July 17, 2025 21:01
@mabdinur mabdinur changed the base branch from main to 3.10 July 17, 2025 21:23
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/_trace/processor/__init__.py                                    @DataDog/apm-sdk-api-python
ddtrace/_trace/tracer.py                                                @DataDog/apm-sdk-api-python
ddtrace/internal/writer/writer.py                                       @DataDog/apm-core-python
ddtrace/settings/_config.py                                             @DataDog/apm-core-python

Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 276 ± 3 ms.

The average import time from base is: 292 ± 9 ms.

The import time difference between this PR and base is: -16.7 ± 0.3 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 14.000 ms (5.08%)
ddtrace 7.189 ms (2.61%)
ddtrace._logger 4.044 ms (1.47%)
ddtrace.internal.telemetry 3.836 ms (1.39%)
ddtrace.internal.telemetry.writer 2.064 ms (0.75%)
http.client 1.135 ms (0.41%)
email.parser 0.544 ms (0.20%)
email.feedparser 0.544 ms (0.20%)
email._policybase 0.544 ms (0.20%)
email.header 0.324 ms (0.12%)
email.charset 0.268 ms (0.10%)
email.utils 0.194 ms (0.07%)
random 0.066 ms (0.02%)
bisect 0.023 ms (0.01%)
_bisect 0.023 ms (0.01%)
email._parseaddr 0.055 ms (0.02%)
calendar 0.055 ms (0.02%)
datetime 0.031 ms (0.01%)
_datetime 0.031 ms (0.01%)
ssl 0.432 ms (0.16%)
_ssl 0.180 ms (0.07%)
email.message 0.039 ms (0.01%)
http 0.034 ms (0.01%)
ddtrace.internal.telemetry.data 0.273 ms (0.10%)
ddtrace.internal.packages 0.199 ms (0.07%)
_sysconfigdata__linux_x86_64-linux-gnu 0.083 ms (0.03%)
sysconfig 0.042 ms (0.02%)
ddtrace.internal.runtime.container 0.033 ms (0.01%)
ddtrace.internal.periodic 0.129 ms (0.05%)
ddtrace.internal._threads 0.129 ms (0.05%)
ddtrace.settings._telemetry 0.101 ms (0.04%)
ddtrace.settings._inferred_base_service 0.044 ms (0.02%)
ddtrace.internal.runtime 0.097 ms (0.04%)
uuid 0.097 ms (0.04%)
platform 0.054 ms (0.02%)
ddtrace.internal.encoding 0.079 ms (0.03%)
ddtrace.internal._encoding 0.062 ms (0.02%)
ddtrace.internal.telemetry.metrics_namespaces 0.066 ms (0.02%)
ddtrace.internal.utils.version 0.057 ms (0.02%)
ddtrace.vendor.packaging.version 0.057 ms (0.02%)
ddtrace.internal.forksafe 0.022 ms (0.01%)
ddtrace.internal.utils.time 0.019 ms (0.01%)
ddtrace.settings._agent 1.465 ms (0.53%)
ddtrace.settings 0.979 ms (0.36%)
ddtrace.settings.http 0.578 ms (0.21%)
ddtrace.internal.utils.cache 0.416 ms (0.15%)
inspect 0.416 ms (0.15%)
ast 0.106 ms (0.04%)
_ast 0.046 ms (0.02%)
dis 0.025 ms (0.01%)
opcode 0.025 ms (0.01%)
_opcode 0.025 ms (0.01%)
ddtrace.internal.utils.http 0.162 ms (0.06%)
email.encoders 0.053 ms (0.02%)
base64 0.053 ms (0.02%)
struct 0.029 ms (0.01%)
_struct 0.029 ms (0.01%)
binascii 0.024 ms (0.01%)
dataclasses 0.039 ms (0.01%)
ddtrace.settings.integration 0.401 ms (0.15%)
ddtrace.vendor.debtcollector 0.385 ms (0.14%)
ddtrace.vendor 0.310 ms (0.11%)
ddtrace.internal.module 0.310 ms (0.11%)
ddtrace.internal.wrapping.context 0.270 ms (0.10%)
ddtrace.internal.wrapping 0.150 ms (0.05%)
bytecode 0.129 ms (0.05%)
bytecode.bytecode 0.091 ms (0.03%)
bytecode.flags 0.091 ms (0.03%)
bytecode.instr 0.091 ms (0.03%)
bytecode.cfg 0.038 ms (0.01%)
ddtrace.internal.utils.inspection 0.058 ms (0.02%)
ddtrace.internal.safety 0.032 ms (0.01%)
wrapt 0.032 ms (0.01%)
wrapt.__wrapt__ 0.032 ms (0.01%)
wrapt._wrappers 0.032 ms (0.01%)
contextvars 0.021 ms (0.01%)
_contextvars 0.021 ms (0.01%)
ddtrace.vendor.debtcollector.moves 0.048 ms (0.02%)
socket 0.266 ms (0.10%)
_socket 0.103 ms (0.04%)
array 0.039 ms (0.01%)
ddtrace.settings._core 0.187 ms (0.07%)
envier 0.079 ms (0.03%)
envier.env 0.079 ms (0.03%)
ddtrace.internal.native 0.062 ms (0.02%)
ddtrace.internal.native._native 0.062 ms (0.02%)
ddtrace.internal.utils.formats 0.178 ms (0.06%)
ddtrace.internal.compat 0.145 ms (0.05%)
pathlib 0.097 ms (0.04%)
urllib.parse 0.047 ms (0.02%)
ntpath 0.011 ms (0.00%)
ipaddress 0.048 ms (0.02%)
ddtrace.internal.constants 0.033 ms (0.01%)
ddtrace.constants 0.033 ms (0.01%)
ddtrace.internal.telemetry.constants 0.030 ms (0.01%)
ddtrace.settings._otel_remapper 0.026 ms (0.01%)
logging 0.122 ms (0.04%)
traceback 0.053 ms (0.02%)
linecache 0.027 ms (0.01%)
tokenize 0.027 ms (0.01%)
typing 0.086 ms (0.03%)
ddtrace.trace 0.925 ms (0.34%)
ddtrace._trace.filters 0.582 ms (0.21%)
ddtrace._trace.processor 0.582 ms (0.21%)
ddtrace._trace.sampler 0.252 ms (0.09%)
ddtrace._trace.span 0.252 ms (0.09%)
ddtrace.internal.sampling 0.058 ms (0.02%)
ddtrace.internal.rate_limiter 0.035 ms (0.01%)
ddtrace._trace.sampling_rule 0.023 ms (0.01%)
ddtrace.internal._rand 0.055 ms (0.02%)
ddtrace._trace._span_pointer 0.037 ms (0.01%)
pprint 0.029 ms (0.01%)
ddtrace.internal.dogstatsd 0.139 ms (0.05%)
ddtrace.vendor.dogstatsd 0.139 ms (0.05%)
ddtrace.vendor.dogstatsd.base 0.139 ms (0.05%)
ddtrace.vendor.dogstatsd.container 0.031 ms (0.01%)
queue 0.018 ms (0.01%)
heapq 0.018 ms (0.01%)
ddtrace.internal.writer 0.134 ms (0.05%)
ddtrace.internal.writer.writer 0.118 ms (0.04%)
gzip 0.041 ms (0.01%)
ddtrace._trace.tracer 0.136 ms (0.05%)
ddtrace.internal.processor.endpoint_call_counter 0.047 ms (0.02%)
ddtrace.internal.debug 0.033 ms (0.01%)
ddtrace._trace.context 0.079 ms (0.03%)
ddtrace._trace._span_link 0.045 ms (0.02%)
ddtrace.settings._config 0.796 ms (0.29%)
ddtrace.internal.gitmetadata 0.506 ms (0.18%)
ddtrace.ext.ci 0.506 ms (0.18%)
ddtrace.ext.git 0.453 ms (0.16%)
tempfile 0.304 ms (0.11%)
shutil 0.094 ms (0.03%)
zlib 0.026 ms (0.01%)
ddtrace.ext 0.021 ms (0.01%)
ddtrace.internal._file_queue 0.084 ms (0.03%)
secrets 0.084 ms (0.03%)
hmac 0.084 ms (0.03%)
_hashlib 0.084 ms (0.03%)
ddtrace.internal.schema 0.052 ms (0.02%)
ddtrace.internal.schema.span_attribute_schema 0.027 ms (0.01%)
ddtrace.internal._unpatched 0.412 ms (0.15%)
subprocess 0.247 ms (0.09%)
contextlib 0.197 ms (0.07%)
fcntl 0.016 ms (0.01%)
json 0.119 ms (0.04%)
json.decoder 0.119 ms (0.04%)
re 0.096 ms (0.03%)
enum 0.096 ms (0.03%)
types 0.040 ms (0.01%)
json.scanner 0.024 ms (0.01%)
_json 0.024 ms (0.01%)
threading 0.046 ms (0.02%)
ddtrace._monkey 0.324 ms (0.12%)
ddtrace.appsec._listeners 0.126 ms (0.05%)
ddtrace.internal.core 0.126 ms (0.05%)
ddtrace.internal.core.event_hub 0.091 ms (0.03%)
ddtrace.vendor.packaging.specifiers 0.090 ms (0.03%)
ddtrace.settings.asm 0.062 ms (0.02%)
ddtrace.bootstrap.sitecustomize 6.811 ms (2.47%)
ddtrace.bootstrap.preload 5.433 ms (1.97%)
ddtrace.internal.remoteconfig.client 0.918 ms (0.33%)
ddtrace.settings.profiling 0.669 ms (0.24%)
ddtrace.vendor.psutil 0.461 ms (0.17%)
ddtrace.vendor.psutil._pslinux 0.202 ms (0.07%)
ddtrace.vendor.psutil._psutil_linux 0.035 ms (0.01%)
glob 0.027 ms (0.01%)
ddtrace.vendor.psutil._common 0.095 ms (0.03%)
ddtrace.vendor.psutil._compat 0.023 ms (0.01%)
pwd 0.012 ms (0.00%)
ddtrace.internal.datadog.profiling.ddup 0.077 ms (0.03%)
ddtrace.internal.datadog.profiling.ddup._ddup 0.077 ms (0.03%)
ddtrace.internal.datadog.profiling.stack_v2 0.042 ms (0.02%)
ddtrace.internal.datadog.profiling.stack_v2._stack_v2 0.042 ms (0.02%)
ddtrace.internal.products 0.651 ms (0.24%)
importlib.metadata 0.623 ms (0.23%)
zipfile 0.365 ms (0.13%)
zipfile._path 0.274 ms (0.10%)
csv 0.072 ms (0.03%)
_csv 0.044 ms (0.02%)
importlib.abc 0.030 ms (0.01%)
importlib.resources 0.030 ms (0.01%)
importlib.resources._common 0.030 ms (0.01%)
importlib.metadata._meta 0.028 ms (0.01%)
importlib.metadata._adapters 0.024 ms (0.01%)
multiprocessing.sharedctypes 0.387 ms (0.14%)
multiprocessing.heap 0.351 ms (0.13%)
mmap 0.319 ms (0.12%)
multiprocessing.util 0.032 ms (0.01%)
ddtrace.internal.symbol_db.remoteconfig 0.229 ms (0.08%)
ddtrace.internal.symbol_db.symbols 0.131 ms (0.05%)
multiprocessing 0.217 ms (0.08%)
multiprocessing.context 0.217 ms (0.08%)
multiprocessing.reduction 0.160 ms (0.06%)
pickle 0.133 ms (0.05%)
_pickle 0.029 ms (0.01%)
_compat_pickle 0.027 ms (0.01%)
multiprocessing.process 0.024 ms (0.01%)
ddtrace.settings.crashtracker 0.179 ms (0.06%)
ddtrace.internal.datadog.profiling.crashtracker 0.136 ms (0.05%)
ddtrace.internal.datadog.profiling.crashtracker._crashtracker 0.136 ms (0.05%)
ddtrace.internal.remoteconfig._connectors 0.161 ms (0.06%)
ctypes 0.135 ms (0.05%)
_ctypes 0.071 ms (0.03%)
ddtrace.internal.flare.flare 0.137 ms (0.05%)
logging.handlers 0.077 ms (0.03%)
ddtrace.appsec._remoteconfiguration 0.115 ms (0.04%)
ddtrace.appsec._capabilities 0.039 ms (0.01%)
ddtrace.debugging._import 0.076 ms (0.03%)
ddtrace.debugging._function.discovery 0.057 ms (0.02%)
ddtrace.internal.remoteconfig.worker 0.060 ms (0.02%)
ddtrace.settings.dynamic_instrumentation 0.048 ms (0.02%)
ddtrace.settings.code_origin 0.032 ms (0.01%)
ddtrace.appsec._common_module_patches 0.468 ms (0.17%)
ddtrace.appsec._asm_request_context 0.428 ms (0.16%)
ddtrace.appsec._utils 0.368 ms (0.13%)
ddtrace._trace.trace_handlers 0.459 ms (0.17%)
ddtrace._trace._inferred_proxy 0.222 ms (0.08%)
ddtrace.propagation.http 0.222 ms (0.08%)
ddtrace.internal._tagset 0.069 ms (0.03%)
ddtrace.contrib.trace_utils 0.105 ms (0.04%)
ddtrace.contrib.internal.trace_utils 0.084 ms (0.03%)
ddtrace.contrib.internal.trace_utils_base 0.043 ms (0.02%)
ddtrace.contrib.internal.redis_utils 0.021 ms (0.01%)
shlex 0.039 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jul 17, 2025

Benchmarks

Benchmark execution time: 2025-07-17 23:54:57

Comparing candidate commit 927e50d in PR branch rachel.yang/incident with baseline commit 1f8c272 in branch 3.10.

Found 0 performance improvements and 36 performance regressions! Performance is the same for 512 metrics, 2 unstable metrics.

scenario:djangosimple-appsec

  • 🟥 execution_time [+6.829ms; +6.995ms] or [+31.780%; +32.552%]

scenario:djangosimple-exception-replay-enabled

  • 🟥 execution_time [+747.124µs; +831.472µs] or [+54.339%; +60.474%]

scenario:djangosimple-iast

  • 🟥 execution_time [+6.785ms; +6.918ms] or [+31.486%; +32.103%]

scenario:djangosimple-span-code-origin

  • 🟥 execution_time [+10.886ms; +11.059ms] or [+39.993%; +40.627%]

scenario:djangosimple-tracer

  • 🟥 execution_time [+6.724ms; +6.891ms] or [+31.149%; +31.921%]

scenario:djangosimple-tracer-and-profiler

  • 🟥 execution_time [+7.233ms; +7.367ms] or [+30.133%; +30.693%]

scenario:djangosimple-tracer-no-caches

  • 🟥 execution_time [+3.945ms; +4.082ms] or [+20.809%; +21.534%]

scenario:djangosimple-tracer-no-databases

  • 🟥 execution_time [+5.095ms; +5.219ms] or [+26.247%; +26.887%]

scenario:djangosimple-tracer-no-middleware

  • 🟥 execution_time [+6.541ms; +6.682ms] or [+30.664%; +31.325%]

scenario:djangosimple-tracer-no-templates

  • 🟥 execution_time [+6.606ms; +6.746ms] or [+31.026%; +31.682%]

scenario:errortrackingdjangosimple-errortracking-enabled-all

  • 🟥 execution_time [+3.937ms; +4.075ms] or [+21.168%; +21.910%]

scenario:errortrackingdjangosimple-errortracking-enabled-user

  • 🟥 execution_time [+3.976ms; +4.103ms] or [+21.343%; +22.025%]

scenario:errortrackingdjangosimple-tracer-enabled

  • 🟥 execution_time [+3.959ms; +4.099ms] or [+21.264%; +22.012%]

scenario:errortrackingflasksqli-errortracking-enabled-all

  • 🟥 execution_time [+1.464ms; +1.489ms] or [+67.964%; +69.101%]

scenario:errortrackingflasksqli-errortracking-enabled-user

  • 🟥 execution_time [+1.448ms; +1.462ms] or [+67.244%; +67.866%]

scenario:errortrackingflasksqli-tracer-enabled

  • 🟥 execution_time [+1.464ms; +1.488ms] or [+67.837%; +68.945%]

scenario:flasksimple-appsec-get

  • 🟥 execution_time [+1.692ms; +1.718ms] or [+36.355%; +36.907%]

scenario:flasksimple-appsec-post

  • 🟥 execution_time [+1.465ms; +1.488ms] or [+23.307%; +23.664%]

scenario:flasksimple-appsec-telemetry

  • 🟥 execution_time [+1.687ms; +1.704ms] or [+36.148%; +36.515%]

scenario:flasksimple-tracer

  • 🟥 execution_time [+1.497ms; +1.513ms] or [+43.579%; +44.041%]

scenario:flasksqli-appsec-enabled

  • 🟥 execution_time [+1.646ms; +1.665ms] or [+41.157%; +41.625%]

scenario:flasksqli-iast-enabled

  • 🟥 execution_time [+1.448ms; +1.498ms] or [+55.122%; +57.022%]

scenario:flasksqli-tracer-enabled

  • 🟥 execution_time [+1.446ms; +1.467ms] or [+67.440%; +68.439%]

scenario:otelspan-start-finish

  • 🟥 execution_time [+241.585ms; +243.173ms] or [+293.690%; +295.622%]

scenario:otelspan-start-finish-telemetry

  • 🟥 execution_time [+242.819ms; +244.897ms] or [+289.423%; +291.900%]

scenario:recursivecomputation-deep

  • 🟥 execution_time [+50.223ms; +51.685ms] or [+16.247%; +16.720%]

scenario:recursivecomputation-deep-profiled

  • 🟥 execution_time [+56.642ms; +59.325ms] or [+16.450%; +17.229%]

scenario:recursivecomputation-medium

  • 🟥 execution_time [+6.681ms; +6.753ms] or [+94.633%; +95.659%]

scenario:recursivecomputation-shallow

  • 🟥 execution_time [+1.601ms; +1.614ms] or [+168.035%; +169.447%]

scenario:span-start-finish

  • 🟥 execution_time [+229.645ms; +232.031ms] or [+454.185%; +458.905%]

scenario:span-start-finish-telemetry

  • 🟥 execution_time [+230.234ms; +231.674ms] or [+439.774%; +442.524%]

scenario:span-start-finish-traceid128

  • 🟥 execution_time [+233.907ms; +235.520ms] or [+429.329%; +432.290%]

scenario:telemetryaddmetric-1-distribution-metric-1-times

  • 🟥 execution_time [+392.096ns; +423.216ns] or [+13.322%; +14.379%]

scenario:tracer-large

  • 🟥 execution_time [+96.052ms; +97.715ms] or [+316.298%; +321.775%]

scenario:tracer-medium

  • 🟥 execution_time [+9.645ms; +9.721ms] or [+321.014%; +323.527%]

scenario:tracer-small

  • 🟥 execution_time [+1.130ms; +1.146ms] or [+332.919%; +337.532%]

@rachelyangdog rachelyangdog changed the title incident-40216 WIP: DD_TRACE_DEBUG logs to info Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants