Skip to content

Commit d21a3a2

Browse files
Resolved last pylint warnings
1 parent 042d9cf commit d21a3a2

File tree

2 files changed

+23
-15
lines changed

2 files changed

+23
-15
lines changed

demo_A_GUI_full.py

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -161,11 +161,14 @@ def __init__(
161161
# Right box
162162
p = {
163163
"alignment": QtCore.Qt.AlignmentFlag.AlignRight
164-
| QtCore.Qt.AlignmentFlag.AlignVCenter
164+
| QtCore.Qt.AlignmentFlag.AlignVCenter,
165+
"parent": self,
165166
}
167+
166168
self.qpbt_exit = QtWid.QPushButton("Exit")
167169
self.qpbt_exit.clicked.connect(self.close)
168170
self.qpbt_exit.setMinimumHeight(30)
171+
169172
self.qlbl_GitHub = QtWid.QLabel(
170173
f'<a href="{__url__}">GitHub source</a>', **p
171174
)
@@ -175,7 +178,8 @@ def __init__(
175178
)
176179
self.qlbl_GitHub.setOpenExternalLinks(True)
177180

178-
vbox_right = QtWid.QVBoxLayout(spacing=4)
181+
vbox_right = QtWid.QVBoxLayout()
182+
vbox_right.setSpacing(4)
179183
vbox_right.addWidget(self.qpbt_exit, stretch=0)
180184
vbox_right.addStretch(1)
181185
vbox_right.addWidget(QtWid.QLabel(__author__, **p))
@@ -286,7 +290,7 @@ def __init__(
286290
self.plot_manager.add_autorange_buttons(linked_plots=self.plot)
287291
self.plot_manager.add_preset_buttons(
288292
linked_plots=self.plot,
289-
linked_curves=self.history_chart_curve,
293+
linked_curves=[self.history_chart_curve],
290294
presets=[
291295
{
292296
"button_label": "0.100",
@@ -309,7 +313,7 @@ def __init__(
309313
],
310314
)
311315
self.plot_manager.add_clear_button(
312-
linked_curves=self.history_chart_curve
316+
linked_curves=[self.history_chart_curve]
313317
)
314318
self.plot_manager.perform_preset(1)
315319

@@ -452,7 +456,7 @@ def DAQ_function() -> bool:
452456
ard.state.time, ard.state.reading_1
453457
)
454458

455-
# Add readings to the log
459+
# Create and add readings to the log
456460
log.update()
457461

458462
return True
@@ -520,13 +524,13 @@ def notify_connection_lost():
520524
"Lost connection to Arduino."
521525
)
522526
print(f"\nCRITICAL ERROR @ {str_msg}")
523-
reply = QtWid.QMessageBox.warning(
524-
window, "CRITICAL ERROR", str_msg, QtWid.QMessageBox.Ok
527+
QtWid.QMessageBox.warning(
528+
window,
529+
"CRITICAL ERROR",
530+
str_msg,
531+
QtWid.QMessageBox.StandardButton.Ok,
525532
)
526533

527-
if reply == QtWid.QMessageBox.Ok:
528-
pass # Leave the GUI open for read-only inspection by the user
529-
530534
# --------------------------------------------------------------------------
531535
# Start the main GUI event loop
532536
# --------------------------------------------------------------------------

demo_C_singlethread_for_comparison.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -171,11 +171,14 @@ def __init__(
171171
# Right box
172172
p = {
173173
"alignment": QtCore.Qt.AlignmentFlag.AlignRight
174-
| QtCore.Qt.AlignmentFlag.AlignVCenter
174+
| QtCore.Qt.AlignmentFlag.AlignVCenter,
175+
"parent": self,
175176
}
177+
176178
self.qpbt_exit = QtWid.QPushButton("Exit")
177179
self.qpbt_exit.clicked.connect(self.close)
178180
self.qpbt_exit.setMinimumHeight(30)
181+
179182
self.qlbl_GitHub = QtWid.QLabel(
180183
f'<a href="{__url__}">GitHub source</a>', **p
181184
)
@@ -185,7 +188,8 @@ def __init__(
185188
)
186189
self.qlbl_GitHub.setOpenExternalLinks(True)
187190

188-
vbox_right = QtWid.QVBoxLayout(spacing=4)
191+
vbox_right = QtWid.QVBoxLayout()
192+
vbox_right.setSpacing(4)
189193
vbox_right.addWidget(self.qpbt_exit, stretch=0)
190194
vbox_right.addStretch(1)
191195
vbox_right.addWidget(QtWid.QLabel(__author__, **p))
@@ -279,7 +283,7 @@ def __init__(
279283
self.plot_manager.add_autorange_buttons(linked_plots=self.plot)
280284
self.plot_manager.add_preset_buttons(
281285
linked_plots=self.plot,
282-
linked_curves=self.history_chart_curve,
286+
linked_curves=[self.history_chart_curve],
283287
presets=[
284288
{
285289
"button_label": "0.100",
@@ -302,7 +306,7 @@ def __init__(
302306
],
303307
)
304308
self.plot_manager.add_clear_button(
305-
linked_curves=self.history_chart_curve
309+
linked_curves=[self.history_chart_curve]
306310
)
307311
self.plot_manager.perform_preset(1)
308312

@@ -489,7 +493,7 @@ def DAQ_function():
489493
ard.state.time, ard.state.reading_1
490494
)
491495

492-
# Add readings to the log
496+
# Create and add readings to the log
493497
log.update()
494498

495499
# We update the GUI right now because this is a singlethread demo

0 commit comments

Comments
 (0)