Skip to content

Commit 1d343ab

Browse files
authored
Change set +x to set -x in CI wasm steps (#74)
These steps benefit from showing the `cargo` command that was run before the resulting build output. Most run multiple `cargo build` commands, sometimes in a loop, such that the output can only be properly understood if the commands are shown. `set +x` is the default (in general, as well as in GitHub Actions unless the value of `shell` is modified with `-x` or `-o xtrace`). It looks like `set -x` was already intended here. Work in GitoxideLabs#2093 confirms a practical benefit of `-x` for understanding these logs. `set +x` was part of the original code of these CI steps when they were introduced in 0d4b804 (GitoxideLabs#735). Its use was preserved and expanded in several changes. In 44ff412 (GitoxideLabs#1668), `set +x` was preserved and also positioned where it would make sense for `set -x` to be. Thus, it appears this started as a small typo and gradually expanded through misreadings, including my own. This fixes that. (See #74 for verification that `set +x` had no effect.)
1 parent 473fe52 commit 1d343ab

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ jobs:
416416
- name: 'WASI only: crates without feature toggle'
417417
if: endsWith(matrix.target, '-wasi')
418418
run: |
419-
set +x
419+
set -x
420420
for crate in gix-sec; do
421421
cargo build -p "$crate" --target "$TARGET"
422422
done
@@ -447,19 +447,19 @@ jobs:
447447
gix-url
448448
gix-validate
449449
)
450-
set +x
450+
set -x
451451
for crate in "${crates[@]}"; do
452452
cargo build -p "$crate" --target "$TARGET"
453453
done
454454
- name: features of gix-features
455455
run: |
456-
set +x
456+
set -x
457457
for feature in progress parallel io-pipe crc32 zlib cache-efficiency-debug; do
458458
cargo build -p gix-features --features "$feature" --target "$TARGET"
459459
done
460460
- name: crates with 'wasm' feature
461461
run: |
462-
set +x
462+
set -x
463463
for crate in gix-pack; do
464464
cargo build -p "$crate" --features wasm --target "$TARGET"
465465
done

0 commit comments

Comments
 (0)