You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These steps benefit from showing the `cargo` command that was run
before the resulting build output. Most run multiple `cargo build`
commands, sometimes in a loop, such that the output can only be
properly understood if the commands are shown. `set +x` is the
default (in general, as well as in GitHub Actions unless the value
of `shell` is modified with `-x` or `-o xtrace`). It looks like
`set -x` was already intended here. Work in GitoxideLabs#2093 confirms a
practical benefit of `-x` for understanding these logs.
`set +x` was part of the original code of these CI steps when they
were introduced in 0d4b804 (GitoxideLabs#735). Its use was preserved and
expanded in several changes. In 44ff412 (GitoxideLabs#1668), `set +x` was
preserved and also positioned where it would make sense for `set
-x` to be. Thus, it appears this started as a small typo and
gradually expanded through misreadings, including my own. This
fixes that.
(See #74 for verification that `set +x` had no effect.)
0 commit comments