Reverted the previous changes and updated the witness-set field-4 serialization

Author: vsubhuman

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "cardano-serialization-lib",
-  "version": "10.0.4-beta.3",
+  "version": "10.0.4-beta.4",
   "description": "(De)serialization functions for the Cardano blockchain along with related utility functions",
   "scripts": {
     "rust:build-nodejs": "(rimraf ./rust/pkg && cd rust; wasm-pack build --target=nodejs; wasm-pack pack) && npm run js:flowgen",

package.json

@@ -1,6 +1,6 @@
 [package]
 name = "cardano-serialization-lib"
-version = "10.0.4-beta.3"
+version = "10.0.4-beta.4"
 edition = "2018"
 authors = ["EMURGO"]
 license = "MIT"

rust/Cargo.lock

@@ -475,13 +475,6 @@ impl PlutusList {
         }
     }
 
-    pub(crate) fn clone_as_definite(&self) -> Self {
-        Self {
-            elems: self.elems.clone(),
-            definite_encoding: Some(true),
-        }
-    }
-
     pub fn len(&self) -> usize {
         self.elems.len()
     }
@@ -1279,12 +1272,12 @@ mod tests {
         // witness_set should have fixed length array
         let mut witness_set = TransactionWitnessSet::new();
         witness_set.set_plutus_data(&list);
-        assert_eq!("a1048101", hex::encode(witness_set.to_bytes()));
+        assert_eq!("a1049f01ff", hex::encode(witness_set.to_bytes()));
 
         list = PlutusList::new();
         list.add(&datum);
         witness_set.set_plutus_data(&list);
-        assert_eq!(format!("a10481{}", datum_cli), hex::encode(witness_set.to_bytes()));
+        assert_eq!(format!("a1049f{}ff", datum_cli), hex::encode(witness_set.to_bytes()));
     }
 
     #[test]

rust/Cargo.toml

@@ -1806,10 +1806,7 @@ impl cbor_event::se::Serialize for TransactionWitnessSet {
         }
         if let Some(field) = &self.plutus_data {
             serializer.write_unsigned_integer(4)?;
-            serializer.write_array(cbor_event::Len::Len(field.len() as u64))?;
-            for i in 0..field.len() {
-              field.get(i).serialize(serializer)?;
-            }
+            field.serialize(serializer)?;
         }
         if let Some(field) = &self.redeemers {
             serializer.write_unsigned_integer(5)?;

rust/src/plutus.rs

@@ -908,7 +908,7 @@ pub fn hash_script_data(redeemers: &Redeemers, cost_models: &Costmdls, datums: O
         */
         buf.push(0x80);
         if let Some(d) = &datums {
-            buf.extend(d.clone_as_definite().to_bytes());
+            buf.extend(d.to_bytes());
         }
         buf.push(0xA0);
     } else {
@@ -921,7 +921,7 @@ pub fn hash_script_data(redeemers: &Redeemers, cost_models: &Costmdls, datums: O
         */
         buf.extend(redeemers.to_bytes());
         if let Some(d) = &datums {
-            buf.extend(d.clone_as_definite().to_bytes());
+            buf.extend(d.to_bytes());
         }
         buf.extend(cost_models.language_views_encoding());
     }
@@ -2173,7 +2173,7 @@ mod tests {
 
         assert_eq!(
             hex::encode(script_data_hash.to_bytes()),
-            "57240d358f8ab6128c4a66340271e4fec39b4971232add308f01a5809313adcf"
+            "4415e6667e6d6bbd992af5092d48e3c2ba9825200d0234d2470068f7f0f178b3"
         );
     }