Merge pull request #228 from SundaeSwap-finance/fix-plutus-list-serialization

Fix plutus list serialization

Author: vsubhuman

rust/src/plutus.rs

@@ -988,10 +988,14 @@ impl Deserialize for PlutusData {
 
 impl cbor_event::se::Serialize for PlutusList {
     fn serialize<'se, W: Write>(&self, serializer: &'se mut Serializer<W>) -> cbor_event::Result<&'se mut Serializer<W>> {
-        serializer.write_array(cbor_event::Len::Len(self.0.len() as u64))?;
+        if self.0.len() == 0 {
+          return Ok(serializer.write_array(cbor_event::Len::Len(0))?);
+        }
+        serializer.write_array(cbor_event::Len::Indefinite)?;
         for element in &self.0 {
             element.serialize(serializer)?;
         }
+        serializer.write_special(cbor_event::Special::Break)?;
         Ok(serializer)
     }
 }
@@ -1164,6 +1168,7 @@ impl Deserialize for Strings {
 #[cfg(test)]
 mod tests {
     use super::*;
+    use hex::*;
 
     #[test]
     pub fn plutus_constr_data() {
@@ -1180,4 +1185,30 @@ mod tests {
         let constr_1854_roundtrip = PlutusData::from_bytes(constr_1854.to_bytes()).unwrap();
         assert_eq!(constr_1854, constr_1854_roundtrip);
     }
-}
+
+    #[test]
+    pub fn plutus_list_serialization_cli_compatibility() {
+        // mimic cardano-cli array encoding, see https://github.com/Emurgo/cardano-serialization-lib/issues/227
+        let datum_cli = "d8799f4100d8799fd8799fd8799f581cffffffffffffffffffffffffffffffffffffffffffffffffffffffffffd8799fd8799fd8799f581cffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffd87a80ff1a002625a0d8799fd879801a000f4240d87a80ffff";
+        let datum = PlutusData::from_bytes(Vec::from_hex(datum_cli).unwrap()).unwrap();
+        assert_eq!(datum_cli, hex::encode(datum.to_bytes()));
+
+        // encode empty arrays as fixed
+        assert_eq!("80", hex::encode(PlutusList::from_bytes(Vec::from_hex("9fff").unwrap()).unwrap().to_bytes()));
+
+        // encode arrays as indefinite length array
+        let mut list = PlutusList::new();
+        list.add(&PlutusData::new_integer(&BigInt::from_str("1").unwrap()));
+        assert_eq!("9f01ff", hex::encode(list.to_bytes()));
+
+        // witness_set should have fixed length array
+        let mut witness_set = TransactionWitnessSet::new();
+        witness_set.set_plutus_data(&list);
+        assert_eq!("a1048101", hex::encode(witness_set.to_bytes()));
+
+        list = PlutusList::new();
+        list.add(&datum);
+        witness_set.set_plutus_data(&list);
+        assert_eq!(format!("a10481{}", datum_cli), hex::encode(witness_set.to_bytes()));
+    }
+}

rust/src/serialization.rs

@@ -1806,7 +1806,10 @@ impl cbor_event::se::Serialize for TransactionWitnessSet {
         }
         if let Some(field) = &self.plutus_data {
             serializer.write_unsigned_integer(4)?;
-            field.serialize(serializer)?;
+            serializer.write_array(cbor_event::Len::Len(field.len() as u64))?;
+            for i in 0..field.len() {
+              field.get(i).serialize(serializer)?;
+            }
         }
         if let Some(field) = &self.redeemers {
             serializer.write_unsigned_integer(5)?;
@@ -3514,4 +3517,4 @@ mod tests {
         let block2 = Block::from_bytes(block.to_bytes()).unwrap();
         assert_eq!(block.to_bytes(), block2.to_bytes());
     }
-}
+}

rust/src/utils.rs

@@ -2169,7 +2169,7 @@ mod tests {
 
         assert_eq!(
             hex::encode(script_data_hash.to_bytes()),
-            "57240d358f8ab6128c4a66340271e4fec39b4971232add308f01a5809313adcf"
+            "4415e6667e6d6bbd992af5092d48e3c2ba9825200d0234d2470068f7f0f178b3"
         );
     }