Skip to content

Commit 3299d84

Browse files
committed
Fixed test issues
1 parent ee1f42b commit 3299d84

File tree

6 files changed

+34
-28
lines changed

6 files changed

+34
-28
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# react-browser-containers
22

3-
A component library with React, Typescript and Storybook.
3+
Browser containers.
44

55
### Run Locally
66

src/components/ChromeBrowser/ChromeBrowser.tsx

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ const ChromeBrowser: React.FC<ChromeBrowserProps> = ({
3939
},
4040
],
4141
shadow = false,
42-
useContentSize = false,
42+
usecontentsize = false,
4343
leftIcons = (
4444
<>
4545
<img src="/arrowback.svg" width={16} height={16} />
@@ -57,8 +57,8 @@ const ChromeBrowser: React.FC<ChromeBrowserProps> = ({
5757
<ThemeProvider theme={theme === "dark" ? darkTheme : lightTheme}>
5858
<BrowserContainer
5959
{...props}
60-
shadow={shadow}
61-
useContentSize={useContentSize}
60+
$shadow={shadow}
61+
$usecontentsize={usecontentsize}
6262
>
6363
<Bar>
6464
<TitleRow>
@@ -74,14 +74,19 @@ const ChromeBrowser: React.FC<ChromeBrowserProps> = ({
7474
if (index === selectedTab) {
7575
return (
7676
<>
77-
<TabDecorator before />
78-
<Tab selected>{tab.name}</Tab>
79-
<TabDecorator after />
77+
<TabDecorator
78+
$before
79+
key={`${index}-decorator-before`}
80+
/>
81+
<Tab selected key={index}>
82+
{tab.name}
83+
</Tab>
84+
<TabDecorator $after key={`${index}-decorator-after`} />
8085
</>
8186
);
8287
} else {
8388
return (
84-
<Tab onClick={() => setSelectedTab(index)}>
89+
<Tab onClick={() => setSelectedTab(index)} key={index}>
8590
{tab.name}
8691
</Tab>
8792
);

src/components/ChromeBrowser/__docs__/Example.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const Example: FC<ChromeBrowserProps> = ({
66
theme,
77
tabs,
88
shadow,
9-
useContentSize,
9+
usecontentsize,
1010
leftIcons,
1111
rightIcons,
1212
children,
@@ -23,7 +23,7 @@ const Example: FC<ChromeBrowserProps> = ({
2323
<ChromeBrowser
2424
theme={theme}
2525
tabs={tabs}
26-
useContentSize={useContentSize}
26+
usecontentsize={usecontentsize}
2727
shadow={shadow}
2828
leftIcons={leftIcons}
2929
rightIcons={rightIcons}
Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
1-
//ChromeBrowser/__test__/ChromeBrowser.test.tsx
21
import { render, screen } from "@testing-library/react";
32
import React from "react";
43
import { describe, expect, it } from "vitest";
5-
import ChromeBrowser from "../ChromeBrowser"; // Import the ChromeBrowser component
4+
import ChromeBrowser from "../ChromeBrowser";
65

7-
describe("ChromeBrowser component", () => {
8-
it("ChromeBrowser should render correctly", () => {
6+
describe("ChromeBrowser", () => {
7+
it("renders correctly", () => {
98
render(<ChromeBrowser />);
10-
const chromeBrowserElement = screen.getByRole("ChromeBrowser"); // Declare the chromeBrowserElement variable
11-
expect(chromeBrowserElement).toBeTruthy(); // Use the correct assertion method
9+
10+
// Assuming the ChromeBrowser component has a title or some identifiable text
11+
const browserElement = screen.getByText(/Hello/i);
12+
expect(browserElement).toBeInTheDocument();
1213
});
1314
});

src/components/ChromeBrowser/props.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export type ChromeBrowserProps = {
66
content: React.ReactNode;
77
}>;
88
shadow?: boolean;
9-
useContentSize?: boolean;
9+
usecontentsize?: boolean;
1010
leftIcons?: React.ReactNode;
1111
rightIcons?: React.ReactNode;
1212
children?: React.ReactNode;

src/components/ChromeBrowser/styles.ts

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,17 @@ export const darkTheme: Theme = {
3333

3434
export const BrowserContainer = styled.div<{
3535
theme: Theme;
36-
shadow?: boolean;
37-
useContentSize?: boolean;
36+
$shadow?: boolean;
37+
$usecontentsize?: boolean;
3838
}>`
3939
border: 1px solid ${({ theme }) => theme.border};
4040
border-radius: 8px;
4141
background-color: ${({ theme }) => theme.bg};
42-
width: ${({ useContentSize }) => (useContentSize ? "inherit" : "100%")};
43-
height: ${({ useContentSize }) => (useContentSize ? "inherit" : "100%")};
42+
width: ${({ $usecontentsize }) => ($usecontentsize ? "inherit" : "100%")};
43+
height: ${({ $usecontentsize }) => ($usecontentsize ? "inherit" : "100%")};
4444
position: relative;
45-
box-shadow: ${(props) =>
46-
props.shadow ? "0 0 40px rgba(0,0,0,0.1)" : "none"};
45+
box-shadow: ${({ $shadow }) =>
46+
$shadow ? "0 0 40px rgba(0,0,0,0.1)" : "none"};
4747
font-family:
4848
system-ui,
4949
-apple-system,
@@ -139,24 +139,24 @@ export const Tab = styled.button<{ selected?: boolean; theme: Theme }>`
139139
`;
140140

141141
export const TabDecorator = styled.div<{
142-
before?: boolean;
143-
after?: boolean;
142+
$before?: boolean;
143+
$after?: boolean;
144144
theme: Theme;
145145
}>`
146146
width: 8px;
147147
height: 8px;
148148
margin-top: auto;
149149
background-color: ${({ theme }) => theme.bg};
150-
margin-right: ${({ after }) => (after ? "-4px" : "0")};
150+
margin-right: ${({ $after }) => ($after ? "-4px" : "0")};
151151
transition: background-color 0.3s;
152152
153153
&::after {
154154
content: "";
155155
display: block;
156156
width: 8px;
157157
height: 8px;
158-
border-bottom-left-radius: ${(props) => (props.before ? "0" : "8px")};
159-
border-bottom-right-radius: ${(props) => (props.after ? "0" : "8px")};
158+
border-bottom-left-radius: ${(props) => (props.$before ? "0" : "8px")};
159+
border-bottom-right-radius: ${(props) => (props.$after ? "0" : "8px")};
160160
background-color: ${({ theme }) => theme.tabBarBg};
161161
}
162162
`;

0 commit comments

Comments
 (0)