Replaced Collection with higher Iterable interface and list with set. (#385)

Author: EranBoudjnah

app/src/test/java/com/mitteloupe/whoami/navigation/mapper/HistoryNavigationEventDestinationMapperTest.kt

@@ -19,7 +19,7 @@ class HistoryNavigationEventDestinationMapperTest(
     companion object {
         @JvmStatic
         @Parameters(name = "Given {0}")
-        fun data(): Collection<Array<*>> = listOf(
+        fun data(): Iterable<Array<*>> = setOf(
             testCase(Back) { navController ->
                 verify(navController).navigateUp()
             }

datasource/implementation/src/test/java/com/mitteloupe/whoami/datasource/history/mapper/NewIpAddressRecordLocalMapperTest.kt

@@ -24,7 +24,7 @@ class NewIpAddressRecordLocalMapperTest(
     companion object {
         @JvmStatic
         @Parameters(name = "Given {0}, time then returns {2}")
-        fun data(): Collection<Array<*>> = listOf(
+        fun data(): Iterable<Array<*>> = setOf(
             testCase(
                 testTitle = "all nulls",
                 ipAddress = "1.1.1.1",

datasource/implementation/src/test/java/com/mitteloupe/whoami/datasource/history/mapper/SavedIpAddressRecordDataMapperTest.kt

@@ -21,7 +21,7 @@ class SavedIpAddressRecordDataMapperTest(
     companion object {
         @JvmStatic
         @Parameters(name = "Given {0}, time then returns {2}")
-        fun data(): Collection<Array<*>> = listOf(
+        fun data(): Iterable<Array<*>> = setOf(
             testCase(
                 testTitle = "all nulls",
                 ipAddress = "1.1.1.1",

datasource/implementation/src/test/java/com/mitteloupe/whoami/datasource/ipaddress/mapper/IpAddressDataMapperTest.kt

@@ -16,7 +16,7 @@ class IpAddressDataMapperTest(
     companion object {
         @JvmStatic
         @Parameters(name = "Given {0}")
-        fun data(): Collection<Array<*>> = listOf(
+        fun data(): Iterable<Array<*>> = setOf(
             testCase("1.1.1.1"),
             testCase("2.3.4.5")
         )

datasource/implementation/src/test/java/com/mitteloupe/whoami/datasource/ipaddressinformation/mapper/IpAddressInformationDataMapperTest.kt

@@ -17,7 +17,7 @@ class IpAddressInformationDataMapperTest(
     companion object {
         @JvmStatic
         @Parameters(name = "Given {0} then returns {1}")
-        fun data(): Collection<Array<*>> = listOf(
+        fun data(): Iterable<Array<*>> = setOf(
             testCase(
                 city = "New York",
                 region = "New York",

history/data/src/test/java/com/mitteloupe/whoami/history/data/mapper/HistoryRecordDeletionDataMapperTest.kt

@@ -17,7 +17,7 @@ class HistoryRecordDeletionDataMapperTest(
     companion object {
         @JvmStatic
         @Parameters(name = "Given {0} then returns {2}")
-        fun data(): Collection<Array<*>> = listOf(
+        fun data(): Iterable<Array<*>> = setOf(
             testCase(ipAddress = "1.2.3.4"),
             testCase(ipAddress = "4.3.2.1")
         )

history/data/src/test/java/com/mitteloupe/whoami/history/data/mapper/SavedIpAddressRecordDomainMapperTest.kt

@@ -18,7 +18,7 @@ class SavedIpAddressRecordDomainMapperTest(
     companion object {
         @JvmStatic
         @Parameters(name = "Given {0} then returns {2}")
-        fun data(): Collection<Array<*>> = listOf(
+        fun data(): Iterable<Array<*>> = setOf(
             testCase(
                 testTitle = "all set",
                 ipAddress = "1.2.3.4",

history/presentation/src/test/java/com/mitteloupe/whoami/history/presentation/mapper/DeleteHistoryRecordRequestDomainMapperTest.kt

@@ -18,7 +18,7 @@ class DeleteHistoryRecordRequestDomainMapperTest(
     companion object {
         @JvmStatic
         @Parameters(name = "Given {0} then returns {2}")
-        fun data(): Collection<Array<*>> = listOf(
+        fun data(): Iterable<Array<*>> = setOf(
             testCase(
                 testTitle = "case 1",
                 ipAddress = "1.1.1.1"

history/presentation/src/test/java/com/mitteloupe/whoami/history/presentation/mapper/SavedIpAddressRecordPresentationMapperTest.kt

@@ -18,7 +18,7 @@ class SavedIpAddressRecordPresentationMapperTest(
     companion object {
         @JvmStatic
         @Parameters(name = "Given {0} then returns {2}")
-        fun data(): Collection<Array<*>> = listOf(
+        fun data(): Iterable<Array<*>> = setOf(
             testCase(
                 testTitle = "all nulls",
                 ipAddress = "1.1.1.1",

history/ui/src/test/java/com/mitteloupe/whoami/history/ui/mapper/HistoryRecordDeletionPresentationMapperTest.kt

@@ -17,7 +17,7 @@ class HistoryRecordDeletionPresentationMapperTest(
     companion object {
         @JvmStatic
         @Parameters(name = "Given {0} then returns {1}")
-        fun data(): Collection<Array<*>> = listOf(
+        fun data(): Iterable<Array<*>> = setOf(
             testCase("0.0.0.0"),
             testCase("255.255.255.255")
         )

history/ui/src/test/java/com/mitteloupe/whoami/history/ui/mapper/HistoryRecordUiMapperTest.kt

@@ -30,7 +30,7 @@ class HistoryRecordUiMapperTest(
     companion object {
         @JvmStatic
         @Parameters(name = "{0} then returns {2}")
-        fun data(): Collection<Array<*>> = listOf(
+        fun data(): Iterable<Array<*>> = setOf(
             testCase(
                 testTitle = "All nulls",
                 ipAddress = "1.2.3.4",

home/data/src/test/java/com/mitteloupe/whoami/home/data/mapper/ConnectionDetailsDataMapperTest.kt

@@ -18,7 +18,7 @@ class ConnectionDetailsDataMapperTest(
     companion object {
         @JvmStatic
         @Parameters(name = "Given {0} then returns {2}")
-        fun data(): Collection<Array<*>> = listOf(
+        fun data(): Iterable<Array<*>> = setOf(
             testCase(
                 testTitle = "all nulls",
                 ipAddress = "1.1.1.1",

home/data/src/test/java/com/mitteloupe/whoami/home/data/mapper/ConnectionDetailsDomainResolverTest.kt

@@ -25,7 +25,7 @@ class ConnectionDetailsDomainResolverTest(
     companion object {
         @JvmStatic
         @Parameters(name = "Given {0} then returns {3}")
-        fun data(): Collection<Array<*>> = listOf(
+        fun data(): Iterable<Array<*>> = setOf(
             connectedWithTestCase(
                 testTitle = "no information",
                 city = null,

home/data/src/test/java/com/mitteloupe/whoami/home/data/mapper/ThrowableDomainMapperTest.kt

@@ -21,7 +21,7 @@ class ThrowableDomainMapperTest(
     companion object {
         @JvmStatic
         @Parameters(name = "Given {0}")
-        fun data(): Collection<Array<*>> = listOf(
+        fun data(): Iterable<Array<*>> = setOf(
             testCase(NoIpAddressDataException()) { exception ->
                 assertThat(
                     exception::class.java,

home/presentation/src/test/java/com/mitteloupe/whoami/home/presentation/mapper/ConnectionDetailsDomainMapperTest.kt

@@ -17,7 +17,7 @@ class ConnectionDetailsDomainMapperTest(
     companion object {
         @JvmStatic
         @Parameters(name = "Given {0} then returns {1}")
-        fun data(): Collection<Array<*>> = listOf(
+        fun data(): Iterable<Array<*>> = setOf(
             connectedTestCase(
                 ipAddress = "1.1.1.1",
                 city = null,

home/presentation/src/test/java/com/mitteloupe/whoami/home/presentation/mapper/ConnectionDetailsPresentationMapperTest.kt

@@ -30,26 +30,26 @@ class ConnectionDetailsPresentationMapperTest(
     companion object {
         @JvmStatic
         @Parameters(name = "Given {0} then returns {1}")
-        fun data(): Collection<Array<*>> = listOf(
+        fun data(): Iterable<Array<*>> = setOf(
             connectedTestCase(
-                "1.2.3.4",
-                null,
-                null,
-                null,
-                null,
-                null,
-                null,
-                null
+                ipAddress = "1.2.3.4",
+                city = null,
+                region = null,
+                country = null,
+                geolocation = null,
+                internetServiceProviderName = null,
+                postCode = null,
+                timeZone = null
             ),
             connectedTestCase(
-                "1.2.3.4",
-                "New York",
-                "New York",
-                "United States",
-                "1.0,1.0",
-                "Whistle",
-                "A123456",
-                "EST"
+                ipAddress = "4.3.2.1",
+                city = "New York",
+                region = "New York",
+                country = "United States",
+                geolocation = "1.0,1.0",
+                internetServiceProviderName = "Whistle",
+                postCode = "A123456",
+                timeZone = "EST"
             ),
             testCase(Disconnected, HomeViewState.Disconnected),
             testCase(Unset, HomeViewState.Loading),

home/presentation/src/test/java/com/mitteloupe/whoami/home/presentation/mapper/ExceptionPresentationMapperTest.kt

@@ -21,7 +21,7 @@ class ExceptionPresentationMapperTest(
     companion object {
         @JvmStatic
         @Parameters(name = "Given {0} then returns {1}")
-        fun data(): Collection<Array<*>> = listOf(
+        fun data(): Iterable<Array<*>> = setOf(
             testCase(ReadFailedDomainException(Throwable()), ErrorPresentationModel.RequestTimeout),
             testCase(NoIpAddressDomainException(), ErrorPresentationModel.NoIpAddress),
             noIpAddressInformationTestCase("1.2.3.4"),

home/ui/src/test/java/com/mitteloupe/whoami/home/ui/mapper/ConnectionDetailsUiMapperTest.kt

@@ -20,7 +20,7 @@ class ConnectionDetailsUiMapperTest(
     companion object {
         @JvmStatic
         @Parameters(name = "Given {0}")
-        fun data(): Collection<Array<*>> = listOf(
+        fun data(): Iterable<Array<*>> = setOf(
             testCase(
                 testTitle = "case 1",
                 ipAddress = "1.2.3.4",

home/ui/src/test/java/com/mitteloupe/whoami/home/ui/mapper/HomeNotificationUiMapperTest.kt

@@ -30,7 +30,7 @@ class HomeNotificationUiMapperTest(
 
         @JvmStatic
         @Parameters(name = "Given {0}")
-        fun data(): Collection<Array<*>> = listOf(
+        fun data(): Iterable<Array<*>> = setOf(
             testCase(
                 "connection saved notification then presents toast",
                 ConnectionSaved(SAVED_CONNECTION_IP_ADDRESS),