Profit/loss summary

[blkaleeb]

Hi, i think the profit data is imprecise.

foreach ($sales as $sale) { foreach ($sale->saleDetails as $saleDetail) { $product_costs += $saleDetail->product->product_cost; } }

this means if you get have the sales qty above 1, you will get the product cost equal to 1 product.
for example:
A = 130.000, we sell A with price 140.000. so the profit is 10.000 per item
if we create sales with 5 qty, we get 570.000 profit instead of 50.000

[RamaWasudewa]

I agree with you. so I try to modify the public function calculateProfit() from: foreach ($sales as $sale) { foreach ($sale->saleDetails as $saleDetail) { $product_costs += $saleDetail->product->product_cost; } } to foreach ($sales as $sale) { foreach ($sale->saleDetails as $saleDetail) { //$product_costs += $saleDetail->product->product_cost; $product_costs += $saleDetail->product->product_cost * $saleDetail->quantity; } }

what do you think about that?

[blkaleeb]

foreach ($sales as $sale) {
            foreach ($sale->saleDetails as $saleDetail) {
                $product_costs += ($saleDetail->quantity * $saleDetail->product->product_cost);
            }
        }

i'm changing it like this, wdyt ? @RamaWasudewa