Fix potential crash when browser returns empty history entries (#144)

Co-authored-by: Simon Heimler <[email protected]>

Author: Fannon

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## [unreleased]
 
+- **FIXED**: Fixed potential crash when browser returns empty history entries (which it shouldn't do).
+
 ## [v1.10.2]
 
 - **FIXED**: Bookmark tagging autocomplete was partly broken. Fixed update of dependency.

popup/js/model/searchData.js

@@ -83,9 +83,9 @@ export async function getSearchData() {
       const browserHistory = []
       const idMap = {}
       for (const item of historyFromApi.concat(historyC)) {
-        if (!idMap[item.id || item.url]) {
+        if (item && item.id & !idMap[item.id]) {
           browserHistory.push(item)
-          idMap[item.id || item.url] = true
+          idMap[item.id] = true
         }
       }