Allow use of Guice 4.x (still only require 3.x) #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All interfaces used jackson-module-guice are compatible between Guice 3.0 and Guice 4.1.
frsyuki
added a commit
to treasure-data/digdag
that referenced
this pull request
Sep 29, 2016
|
Sounds reasonable to me, as long as maven build and release still work (few years ago I think there were problems with version ranges)? |
cowtowncoder
changed the title
cowtowncoder
added a commit
that referenced
this pull request
Sep 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were many changes in Guice 4.0. But all interfaces actually used in jackson-module-guice are still compatible between Guice 3.0 and Guice 4.1.
Changes of Guice 4.1 were conservative. I think that it is reasonable to expand range from
4.0]to5.0).It might be better that README.md recommends users to specify a fixed version of Guice as well as dependency to jackson-module-guice in application's pom.xml file.