Skip to content

Commit 238461a

Browse files
authored
Add gix-diff WASM check, even though gix-path covers it (#75)
As noted in #2092, the `wasm` jobs on CI do not test `gix-diff` directly. However, my prediction there that breakage would not be detected on CI was mistaken, because those jobs do test the `wasm` feature of `gix-pack`. The `gix-pack` crate depends on `gix-diff`, and its `wasm` feature enable the `gix-diff` one. This nonetheless adds an explicit check for `gix-diff`. This `gix-diff` check does not attempt to build default features, since some fail on some WASM targets. But the preexisting `gix-pack` check does still build the default features of `gix-pack`, which are compatible with WASM targets. The efficacy of these checks, as well as the need to pass `--no-default-features` for `gix-diff`, can be confirmed by examining CI results for various fragments of this change experimented on in EliahKagan#75. This also demonstrates that CI is capable of catching at least some breakages related to the `wasm` feature of `gix-diff`, and thus may be sufficient to support moving forward with #2092.
1 parent 8f51845 commit 238461a

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -460,9 +460,8 @@ jobs:
460460
- name: crates with 'wasm' feature
461461
run: |
462462
set -x
463-
for crate in gix-pack; do
464-
cargo build -p "$crate" --features wasm --target "$TARGET"
465-
done
463+
cargo build -p gix-diff --no-default-features --features wasm --target "$TARGET"
464+
cargo build -p gix-pack --features wasm --target "$TARGET"
466465
- name: gix-pack with all features (including wasm)
467466
run: cargo build -p gix-pack --all-features --target "$TARGET"
468467

0 commit comments

Comments
 (0)