You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add gix-diff WASM check, even though gix-path covers it (#75)
As noted in #2092, the `wasm` jobs on CI do not test `gix-diff`
directly. However, my prediction there that breakage would not be
detected on CI was mistaken, because those jobs do test the `wasm`
feature of `gix-pack`. The `gix-pack` crate depends on `gix-diff`,
and its `wasm` feature enable the `gix-diff` one.
This nonetheless adds an explicit check for `gix-diff`. This
`gix-diff` check does not attempt to build default features, since
some fail on some WASM targets. But the preexisting `gix-pack`
check does still build the default features of `gix-pack`, which
are compatible with WASM targets.
The efficacy of these checks, as well as the need to pass
`--no-default-features` for `gix-diff`, can be confirmed by
examining CI results for various fragments of this change
experimented on in EliahKagan#75. This also demonstrates that CI is
capable of catching at least some breakages related to the `wasm`
feature of `gix-diff`, and thus may be sufficient to support moving
forward with #2092.
0 commit comments