Skip to content

feat: support special labels parsing in prom remote write #6302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: support special labels parsing in prom remote write #6302

wants to merge 4 commits into from
+235 −21

Conversation

shuiyisong
Copy link
Contributor

@shuiyisong shuiyisong commented Jun 11, 2025 •
edited by sunng87
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#6156

What's changed and what's your intention?

This PR adds support for parsing and setting the schema and physical table options from the Prom remote write's label value.

  • __database__ for setting the schema
  • __physical_table__ for setting the physical table info

Note: __physical_table__ only takes effect upon first insertion(which is create-table-upon-insert process).

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@shuiyisong shuiyisong requested a review from a team as a code owner June 11, 2025 21:53
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 11, 2025
This was linked to issues Jun 11, 2025
Prometheus Remote Write: Override default database using meta label #6292
Open
Support Dynamic Routing of Prometheus Remote Write to Physical Tables via Metric Labels #6156
Open
@github-actions github-actions bot added docs-required This change requires docs update. and removed docs-not-required This change does not impact docs. labels Jun 11, 2025
@daviderli614 daviderli614 mentioned this pull request Jun 11, 2025
Open
@sunng87
Copy link
Member

sunng87 commented Jun 12, 2025

@waynexia @v0y4g3r please confirm this, we have user waiting for this feature. thanks!

killme2008
killme2008 reviewed Jun 13, 2025
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killme2008 killme2008 killme2008 left review comments

@sunng87 sunng87 sunng87 approved these changes

@v0y4g3r v0y4g3r Awaiting requested review from v0y4g3r

@waynexia waynexia Awaiting requested review from waynexia

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
docs-required This change requires docs update.
Projects
None yet
Milestone
No milestone
3 participants
@shuiyisong @sunng87 @killme2008