Skip to content

fix(frontend): resolve useInfiniteLiveSubscribers hook or operator bug #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

yassinedorbozgithub
Copy link
Collaborator

@yassinedorbozgithub yassinedorbozgithub commented May 31, 2025

Motivation

The main motivation of this PR is to update the useInfiniteLiveSubscribers hook to be able to support multiple or operators from channels filter or/and search or filters.
This fix will make available the feature of searching by text and by channels filters simultaneously .

Fixes #1056

Type of change:

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

Summary by CodeRabbit

  • Bug Fixes

    • Improved filtering logic to ensure search results include both existing search conditions and selected channel filters.
  • Chores

    • Updated copyright year in file header.

Copy link

coderabbitai bot commented May 31, 2025

Warning

Rate limit exceeded

@yassinedorbozgithub has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 41 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between f1c7d88 and 1543843.

📒 Files selected for processing (1)
  • frontend/src/components/inbox/hooks/useInfiniteLiveSubscribers.ts (2 hunks)

Walkthrough

The code modifies how the where clause is constructed for querying subscribers in the inbox component. When channel filters are applied alongside other search conditions, the or clause now merges both sets of conditions instead of replacing them. Additionally, the file's copyright year is updated.

Changes

File(s) Change Summary
frontend/src/components/inbox/hooks/useInfiniteLiveSubscribers.ts Merges channel filter conditions with existing search payload in the or clause; updates copyright

Sequence Diagram(s)

sequenceDiagram
    participant UI as Inbox UI
    participant Hook as useInfiniteLiveSubscribers
    participant API as Subscribers API

    UI->>Hook: Provide searchPayload and channels
    Hook->>Hook: Construct params with merged 'or' clause (searchPayload + channel filters)
    Hook->>API: Query subscribers with params
    API-->>Hook: Return filtered subscribers
    Hook-->>UI: Provide subscribers data
Loading

Assessment against linked issues

Objective Addressed Explanation
Fix channel filter to work with keyword search in inbox (#1056)

Suggested labels

needs-review

Suggested reviewers

  • marrouchi
  • medchedli

Poem

In the inbox where channels and keywords meet,
The filters now merge and never retreat.
Bugs are squashed with a hop and a cheer,
As CodeRabbit’s code brings clarity near.
2025 shines bright in the header’s new light,
Inbox searches work perfectly right!
🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ef4c61b and f1c7d88.

📒 Files selected for processing (1)
  • frontend/src/components/inbox/hooks/useInfiniteLiveSubscribers.ts (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: API-Tests
  • GitHub Check: Frontend Tests
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
frontend/src/components/inbox/hooks/useInfiniteLiveSubscribers.ts (1)

2-2: LGTM: Copyright year updated appropriately.

The copyright year update from 2024 to 2025 is correct.

@yassinedorbozgithub yassinedorbozgithub changed the title fix(frontend): resolve useInfiniteLiveSubscribers hook or operator issue fix(frontend): resolve useInfiniteLiveSubscribers hook or operator bug May 31, 2025
@marrouchi marrouchi merged commit d70b108 into main Jun 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Inbox : Channel filter ineffective when combined with keyword search inbox search
2 participants