Skip to content

Commit b3a9f23

Browse files
refactor: lower radio create timeout, update docs
1 parent d304083 commit b3a9f23

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

README.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
[![GitHub go.mod Go version](https://img.shields.io/github/go-mod/go-version/itsnotgoodname/reciva-web-remote)](./go.mod)
77
[![Go Report Card](https://goreportcard.com/badge/github.com/ItsNotGoodName/reciva-web-remote)](https://goreportcard.com/report/github.com/ItsNotGoodName/reciva-web-remote)
88

9-
Control your legacy Reciva based internet radios (Crane, Grace Digital, Tangent, etc.) via REST api or web browser.
9+
Control your legacy Reciva based internet radios (Crane, Grace Digital, Tangent, etc.) via web browser or REST API.
1010

1111
![Desktop Demo](/assets/desktop-demo.png)
1212

@@ -17,7 +17,7 @@ Control your legacy Reciva based internet radios (Crane, Grace Digital, Tangent,
1717
- Change radio volume
1818
- Change radio audio source (unreliable)
1919
- Play radio presets (make sure audio source is `Internet radio` or else it will hang)
20-
- [Host playlists](###host-playlists) for radios
20+
- [Host playlists](#host-playlists) for radios
2121

2222
## Running
2323

@@ -108,7 +108,7 @@ The contents of the playlists can be changed in the web interface.
108108
}
109109
```
110110

111-
### Routes
111+
### Endpoints
112112

113113
| Method | Endpoint | Description |
114114
| ------ | ------------------------------ | ------------------------- |
@@ -126,7 +126,7 @@ The contents of the playlists can be changed in the web interface.
126126
| GET | /api/states | List States |
127127
| GET | /api/state/{uuid} | Get State |
128128
| PATCH | /api/state/{uuid} | Modify State |
129-
| WS | /api/ws | Websocket |
129+
| WS | /api/ws | WebSocket |
130130

131131
## Build
132132

@@ -173,5 +173,4 @@ make dev-backend
173173
- Add volume slider in web interface
174174
- Make [Podman](https://podman.io/) an optional requirement for Make
175175
- Discover radios on a timer
176-
- Better error handling in `upnp` package when using `retry` package to prevent spamming when there is a UPnP error (ex. invalid action)
177176
- Add events (ex. radios discovered, presets changed)

core/radio/hub.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ func (hs *HubServiceImpl) Background(ctx context.Context, doneC chan<- struct{})
6868
wg.Add(1)
6969
go (func(idx int) {
7070
// Timeout for creating radio
71-
sctx, cancel := context.WithTimeout(ctx, 45*time.Second)
71+
sctx, cancel := context.WithTimeout(ctx, 25*time.Second)
7272
defer cancel()
7373

7474
// Create radio

0 commit comments

Comments
 (0)