Skip to content

Commit 31f6605

Browse files
committed
Filter out IExceptionFieldDeclaration for IExceptionDeclaration.
1 parent 12a6bdc commit 31f6605

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

ReSharper.FSharp/src/FSharp.Common/src/Settings/FSharpOptionsPageBase.fs

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ type FSharpOptionsPageBase(lifetime, optionsPageContext, settings) =
2020
member x.AddString(text: string, getter: Expression<Func<_,_>>) =
2121
x.AddString(text, settings.GetValueProperty(lifetime, getter))
2222

23-
member x.AddDescription(text) =
23+
member x.AddDescription(text: string) =
2424
use indent = x.Indent()
2525
x.AddRichText(RichText(text)) |> ignore
2626

27-
member x.AddBool(text, property: IProperty<_>) =
27+
member x.AddBool(text: string, property: IProperty<_>) =
2828
x.AddBoolOption(property, RichText(text), text) |> ignore
2929

3030
member x.AddHeader(text: string) =

ReSharper.FSharp/src/FSharp.Psi.Services/src/Generate/GenerateSignatureProvider.fs

+6-1
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,12 @@ type FSharpGenerateSignatureBuilder() =
192192
factory.CreateTypeMemberSignature(sigStrings)
193193
| :? IExceptionDeclaration as exceptionDeclaration ->
194194
let sigExceptionDeclaration = exceptionDeclaration.Copy()
195-
if not (Seq.isEmpty exceptionDeclaration.MemberDeclarations) then
195+
let memberDeclarations =
196+
exceptionDeclaration.MemberDeclarations
197+
|> Seq.filter (function | :? IExceptionFieldDeclaration -> false | _ -> true)
198+
|> Seq.toArray
199+
200+
if memberDeclarations.Length > 0 then
196201
let sigMembers =
197202
exceptionDeclaration.TypeMembers
198203
|> Seq.choose (createMemberDeclaration >> Option.ofObj)

0 commit comments

Comments
 (0)