Skip to content

Documentation tracking issue! #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks done
josephsdavid opened this issue May 23, 2022 · 3 comments
Closed
5 tasks done

Documentation tracking issue! #25

josephsdavid opened this issue May 23, 2022 · 3 comments

Comments

@josephsdavid
Copy link
Contributor

josephsdavid commented May 23, 2022

  • Add skeleton docstrings to fill out
  • Document internal helpers
  • Document linear regression function and structs
  • Document binary regression functions and structs
  • Document count regression functions and structs
@josephsdavid
Copy link
Contributor Author

A few questions:

A few questions:

How do I document:

function MMI.predict_mean(model::LinearBinaryClassifier, (fitresult, _), Xnew)

and

function MMI.predict(model::LinearBinaryClassifier, (fitresult, decode), Xnew)

?

Is there a reason we preemptively unpack this iterable instead of having one named parameter the function takes in and then unpacking it internally?

Secondarily, at what point do we go from:

"""
    function foo(X, y, z)

blurb
"""

to

"""
    function foo(X, y, z)

blurb

# Arguments
- `X`:
- ....
"""

I am relatively new to julia and this has been bothering me for a bit :)

@ablaom
Copy link
Member

ablaom commented May 23, 2022

A few questions:

A few questions:

How do I document:

function MMI.predict_mean(model::LinearBinaryClassifier, (fitresult, _), Xnew)

You don't. See comments at #26

and

function MMI.predict(model::LinearBinaryClassifier, (fitresult, decode), Xnew)

?

Is there a reason we preemptively unpack this iterable instead of having one named parameter the function takes in and then unpacking it internally?

I guess this is mainly a style point. I doubt it will compile any differently either way.

Secondarily, at what point do we go from:

"""
    function foo(X, y, z)

blurb
"""

to

"""
    function foo(X, y, z)

blurb

# Arguments
- `X`:
- ....
"""

I am relatively new to julia and this has been bothering me for a bit :)

Yeah good question. Personally, I usually unpack the options when they no longer fit on one line of the doc-header. There is a style guide that we say we adopt: https://github.com/invenia/BlueStyle Maybe it says there.

In the case of the current documentation roll-out though, this point is mute. You always unpack the options (hyper-parameters) in a model doc-string

@josephsdavid
Copy link
Contributor Author

Yeah good question. Personally, I usually unpack the options when they no longer fit on one line of the doc-header. There is a style guide that we say we adopt: https://github.com/invenia/BlueStyle Maybe it says there.

Ah this is super helpful! I will read through this more closely!

@ablaom ablaom closed this as completed Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants