Skip to content

fix microbenchmarks to be more alike #13729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
StefanKarpinski opened this issue Oct 22, 2015 · 4 comments
Closed

fix microbenchmarks to be more alike #13729

StefanKarpinski opened this issue Oct 22, 2015 · 4 comments
Labels
help wanted Indicates that a maintainer wants help on an issue or pull request performance Must go faster

Comments

@StefanKarpinski
Copy link
Member

See: #13673

@kshyatt kshyatt added the performance Must go faster label Nov 25, 2015
@kshyatt
Copy link
Contributor

kshyatt commented Nov 25, 2015

I think this is perf related? Could we get, like, a paragraph summary of what the situation is?

@ViralBShah ViralBShah added the potential benchmark Could make a good benchmark in BaseBenchmarks label Dec 7, 2015
@ViralBShah
Copy link
Member

The issue is that the original benchmark is supposed to use 2d indexing in construction of the complex array in mandel. Many of the versions are hand-linearized (C, Java, Fortran, Lua, Go, etc.).

The other issue is that some of the benchmarks are not even creating the array and just summing up values upon computation. The summing is a correctness check, but the benchmark is to compute the complex array. I notice this in at least the Java and Fortran versions.

@eschnett
Copy link
Contributor

eschnett commented Dec 7, 2015

You could change the correctness check to access the array elements in an "unpredictable" order (and accessing some array elements twice, maybe not accessing all of them). This should prevent that optimization.

@JeffBezanson JeffBezanson modified the milestones: 0.5.x, 0.5.0 Jan 27, 2016
@jrevels jrevels removed the potential benchmark Could make a good benchmark in BaseBenchmarks label Jan 29, 2016
@StefanKarpinski StefanKarpinski added help wanted Indicates that a maintainer wants help on an issue or pull request and removed help wanted Indicates that a maintainer wants help on an issue or pull request labels Oct 27, 2016
@JeffBezanson JeffBezanson modified the milestones: 0.5.x, 1.0.x May 21, 2018
@KristofferC
Copy link
Member

Moved to JuliaLang/Microbenchmarks#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Indicates that a maintainer wants help on an issue or pull request performance Must go faster
Projects
None yet
Development

No branches or pull requests

7 participants