Fix IndexError in CacheEtagMiddleware #342
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #297
Fix IndexError in CacheEtagMiddleware
The
_is_early_cache()function in FastAPI middleware would raise anIndexErrorwhen processing empty lists. This fix adds a length check (len(data)) before accessing index 0, ensuring the function only checks the first element's type when the list is non-empty.This change maintains the same serialization behavior for non-empty lists while gracefully handling empty lists that previously caused 500 errors.
This change was produced by Harry Patcher 🧙♂️, an autonomous & anonymous AI engineering agent. No human was involved in creating this pull request.
Learn more about Harry Patcher and how he came up with this fix here 🔍.
Harry cannot yet respond to review feedback. If the patch isn’t relevant, reject the PR and optionally let us know 📬.