Skip to content

Commit 1b07e99

Browse files
committed
Fix test
1 parent 0dbab47 commit 1b07e99

File tree

1 file changed

+17
-9
lines changed

1 file changed

+17
-9
lines changed

libs/labelbox/tests/integration/test_workflow.py

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -785,11 +785,16 @@ def test_reset_to_initial_nodes_preserves_existing_ids(client):
785785
workflow = project.get_workflow()
786786
initial_nodes = workflow.reset_to_initial_nodes()
787787

788+
# Create a complete workflow by adding nodes and edges
789+
done_node = workflow.add_node(type=NodeType.Done, name="Test Done")
790+
workflow.add_edge(initial_nodes.labeling, done_node)
791+
workflow.add_edge(initial_nodes.rework, done_node)
792+
788793
# Record the original IDs
789794
original_labeling_id = initial_nodes.labeling.id
790795
original_rework_id = initial_nodes.rework.id
791796

792-
# Update the workflow to save the initial state
797+
# Update the workflow to save the initial state (now valid)
793798
workflow.update_config()
794799

795800
# Reset again with new configuration
@@ -804,6 +809,11 @@ def test_reset_to_initial_nodes_preserves_existing_ids(client):
804809
),
805810
)
806811

812+
# Rebuild the workflow structure after reset
813+
done_node = workflow.add_node(type=NodeType.Done, name="Test Done")
814+
workflow.add_edge(new_initial_nodes.labeling, done_node)
815+
workflow.add_edge(new_initial_nodes.rework, done_node)
816+
807817
# Verify that the IDs are preserved
808818
assert new_initial_nodes.labeling.id == original_labeling_id, (
809819
f"InitialLabelingNode ID changed from {original_labeling_id} to {new_initial_nodes.labeling.id}. "
@@ -1013,12 +1023,10 @@ def test_edge_id_format_with_different_handles(client):
10131023
review_node, rework_node, NodeOutput.Rejected
10141024
)
10151025

1016-
# Verify edge ID formats
1017-
expected_approved_id = (
1018-
f"xy-edge__{review_node.id}approved-{done_node.id}in"
1019-
)
1026+
# Verify edge ID formats - NodeOutput.Approved maps to "if", NodeOutput.Rejected maps to "else"
1027+
expected_approved_id = f"xy-edge__{review_node.id}if-{done_node.id}in"
10201028
expected_rejected_id = (
1021-
f"xy-edge__{review_node.id}rejected-{rework_node.id}in"
1029+
f"xy-edge__{review_node.id}else-{rework_node.id}in"
10221030
)
10231031

10241032
assert (
@@ -1028,9 +1036,9 @@ def test_edge_id_format_with_different_handles(client):
10281036
rejected_edge.id == expected_rejected_id
10291037
), f"Rejected edge ID format incorrect. Expected: {expected_rejected_id}, Got: {rejected_edge.id}"
10301038

1031-
# Verify handle values
1032-
assert approved_edge.sourceHandle == "approved"
1033-
assert rejected_edge.sourceHandle == "rejected"
1039+
# Verify handle values - NodeOutput.Approved maps to "if", NodeOutput.Rejected maps to "else"
1040+
assert approved_edge.sourceHandle == "if"
1041+
assert rejected_edge.sourceHandle == "else"
10341042
assert approved_edge.targetHandle == "in"
10351043
assert rejected_edge.targetHandle == "in"
10361044

0 commit comments

Comments
 (0)