Skip to content

Commit 237ec10

Browse files
Merge pull request #847 from Labelbox/sdubinin/al-000-fix-confidence
[AL-000] Fixed confidence for TextEntity
2 parents 982c410 + 4d8e5fd commit 237ec10

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

labelbox/data/serialization/ndjson/objects.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -352,11 +352,14 @@ def to_common(self) -> TextEntity:
352352
return TextEntity(start=self.location.start, end=self.location.end)
353353

354354
@classmethod
355-
def from_common(cls, text_entity: TextEntity,
356-
classifications: List[ClassificationAnnotation], name: str,
357-
feature_schema_id: Cuid, extra: Dict[str, Any],
358-
data: Union[ImageData,
359-
TextData], confidence: float) -> "NDTextEntity":
355+
def from_common(cls,
356+
text_entity: TextEntity,
357+
classifications: List[ClassificationAnnotation],
358+
name: str,
359+
feature_schema_id: Cuid,
360+
extra: Dict[str, Any],
361+
data: Union[ImageData, TextData],
362+
confidence: Optional[float] = None) -> "NDTextEntity":
360363
return cls(location=Location(
361364
start=text_entity.start,
362365
end=text_entity.end,

tests/data/serialization/ndjson/test_text_entity.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"tests/data/assets/ndjson/text_entity_without_confidence_import.json"
1111
])
1212
def test_text_entity_import(filename: str):
13-
with open('tests/data/assets/ndjson/text_entity_import.json', 'r') as file:
13+
with open(filename, 'r') as file:
1414
data = json.load(file)
1515
res = NDJsonConverter.deserialize(data).as_list()
1616
res = list(NDJsonConverter.serialize(res))

0 commit comments

Comments
 (0)