Skip to content

Commit f14ce3b

Browse files
authored
Revert "Must pass model run id in order for model slices to work corr… (#1388)
No sdk test for this PR, new feature revert, safe to force-merge in the interest of time
2 parents d48b0b5 + 968efad commit f14ce3b

File tree

1 file changed

+5
-19
lines changed

1 file changed

+5
-19
lines changed

labelbox/schema/slice.py

Lines changed: 5 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -239,10 +239,9 @@ class ModelSlice(Slice):
239239
@classmethod
240240
def query_str(cls):
241241
query_str = """
242-
query getDataRowIdenfifiersBySavedModelQueryPyApi($id: ID!, $modelRunId: ID, $from: DataRowIdentifierCursorInput, $first: Int!) {
242+
query getDataRowIdenfifiersBySavedModelQueryPyApi($id: ID!, $from: DataRowIdentifierCursorInput, $first: Int!) {
243243
getDataRowIdentifiersBySavedModelQuery(input: {
244244
savedQueryId: $id,
245-
modelRunId: $modelRunId,
246245
after: $from
247246
first: $first
248247
}) {
@@ -264,23 +263,17 @@ def query_str(cls):
264263
"""
265264
return query_str
266265

267-
def get_data_row_ids(self, model_run_id: str) -> PaginatedCollection:
266+
def get_data_row_ids(self) -> PaginatedCollection:
268267
"""
269268
Fetches all data row ids that match this Slice
270269
271-
Params
272-
model_run_id: str, required, uid or cuid of model run
273-
274270
Returns:
275271
A PaginatedCollection of data row ids
276272
"""
277273
return PaginatedCollection(
278274
client=self.client,
279275
query=ModelSlice.query_str(),
280-
params={
281-
'id': str(self.uid),
282-
'modelRunId': model_run_id
283-
},
276+
params={'id': str(self.uid)},
284277
dereferencing=['getDataRowIdentifiersBySavedModelQuery', 'nodes'],
285278
obj_class=lambda _, data_row_id_and_gk: data_row_id_and_gk.get('id'
286279
),
@@ -289,24 +282,17 @@ def get_data_row_ids(self, model_run_id: str) -> PaginatedCollection:
289282
'endCursor'
290283
])
291284

292-
def get_data_row_identifiers(self,
293-
model_run_id: str) -> PaginatedCollection:
285+
def get_data_row_identifiers(self) -> PaginatedCollection:
294286
"""
295287
Fetches all data row ids and global keys (where defined) that match this Slice
296288
297-
Params:
298-
model_run_id : str, required, uid or cuid of model run
299-
300289
Returns:
301290
A PaginatedCollection of Slice.DataRowIdAndGlobalKey
302291
"""
303292
return PaginatedCollection(
304293
client=self.client,
305294
query=ModelSlice.query_str(),
306-
params={
307-
'id': str(self.uid),
308-
'modelRunId': model_run_id
309-
},
295+
params={'id': str(self.uid)},
310296
dereferencing=['getDataRowIdentifiersBySavedModelQuery', 'nodes'],
311297
obj_class=lambda _, data_row_id_and_gk: Slice.DataRowIdAndGlobalKey(
312298
data_row_id_and_gk.get('id'),

0 commit comments

Comments
 (0)