Skip to content

When browser is in French language, requesting a code doesn't work. #4882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Olybo opened this issue Apr 25, 2025 · 3 comments · Fixed by #4920
Open

When browser is in French language, requesting a code doesn't work. #4882

Olybo opened this issue Apr 25, 2025 · 3 comments · Fixed by #4920
Assignees
Labels
backend Backend task bug Something isn't working frontend Frontend task

Comments

@Olybo
Copy link

Olybo commented Apr 25, 2025

Describe the bug
When browser is in French language, requesting a code doesn't work.
I test it also with English, German and Italian, works well.

To Reproduce
Steps to reproduce the behaviour :

Requirements :

  • First, request a signature with email address.
  • Set your browser language in French

Step :

  • I'm not an authenticated user
  • Click on the button of the email received to sign a document
  • Click on "Définissez votre signature."
  • Draw signature
  • Click on "Sauvegarder"
  • Click on "Sauvegarder"
  • Click on "Signer le document"
  • Enter the email
  • Click on "Demander un code".

The notification displayed is : "La requête de signature du fichier à été correctement soumise."
Which mean "The file signature request has been correctly submitted."

No code is received by email.

Expected behavior
The message of the notification should be "The code to sign file was successfully requested." in french "Le code pour signer le fichier a été demandé avec succès."

Environment information (please complete the following information):

  • OS: Client: Linux ; Server: Podman containers Nexcloud AIO
  • Browser : Tested with Firefox and Ungoogled-chromium both in French language
  • LibreSign Version 10.7.2
  • Nextcloud Server Version 30.0.8
  • Logs :

Request with English language

Request :

curl 'https://--removed--.org/ocs/v2.php/apps/libresign/api/v1/sign/uuid/0ea4af05-efda-4555-8783/code' \
  -H 'accept: application/json, text/plain, */*' \
  -H 'accept-language: en-US,en;q=0.9,fr-FR;q=0.8,fr;q=0.7,en-GB;q=0.6' \
  -H 'content-type: application/json' \
  -b '__Host-nc_sameSiteCookielax=true; __Host-nc_sameSiteCookiestrict=true; oc_sessionPassphrase=--removed--; ocufnhdp8gk8=--removed--' \
  -H 'dnt: 1' \
  -H 'origin: https://--removed--.org' \
  -H 'priority: u=1, i' \
  -H 'requesttoken: --revoved--' \
  -H 'sec-ch-ua: "Chromium";v="135", "Not-A.Brand";v="8"' \
  -H 'sec-ch-ua-mobile: ?0' \
  -H 'sec-ch-ua-platform: "Linux"' \
  -H 'sec-fetch-dest: empty' \
  -H 'sec-fetch-mode: cors' \
  -H 'sec-fetch-site: same-origin' \
  -H 'user-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/135.0.0.0 Safari/537.36' \
  -H 'x-requested-with: XMLHttpRequest, XMLHttpRequest' \
  --data-raw '{"identify":"--removed--","identifyMethod":"email","signMethod":"emailToken"}'


Response :

{"ocs":{"meta":{"status":"ok","statuscode":200,"message":"OK"},"data":{"message":"The code to sign file was successfully requested."}}}

Request with French language

Request :

curl 'https://--removed--.org/ocs/v2.php/apps/libresign/api/v1/sign/uuid/0ea4af05-efda-4555-8783-7ec0d0f3e266/code' \
  -H 'accept: application/json, text/plain, */*' \
  -H 'accept-language: fr-FR,fr;q=0.9,en-US;q=0.8,en;q=0.7,en-GB;q=0.6' \
  -H 'content-type: application/json' \
  -b '__Host-nc_sameSiteCookielax=true; __Host-nc_sameSiteCookiestrict=true; oc_sessionPassphrase=--removed--; ocufnhdp8gk8=--removed--' \
  -H 'dnt: 1' \
  -H 'origin: https://--removed--.org' \
  -H 'priority: u=1, i' \
  -H 'requesttoken: --removed--' \
  -H 'sec-ch-ua: "Chromium";v="135", "Not-A.Brand";v="8"' \
  -H 'sec-ch-ua-mobile: ?0' \
  -H 'sec-ch-ua-platform: "Linux"' \
  -H 'sec-fetch-dest: empty' \
  -H 'sec-fetch-mode: cors' \
  -H 'sec-fetch-site: same-origin' \
  -H 'user-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/135.0.0.0 Safari/537.36' \
  -H 'x-requested-with: XMLHttpRequest, XMLHttpRequest' \
  --data-raw '{"identify":"--removed--","identifyMethod":"email","signMethod":"emailToken"}'

Response :

{"ocs":{"meta":{"status":"ok","statuscode":200,"message":"OK"},"data":{"message":"La requ\u00eate de signature du fichier \u00e0 \u00e9t\u00e9 correctement soumise."}}}
@github-project-automation github-project-automation bot moved this to 0. Needs triage in Roadmap Apr 25, 2025
@vitormattos vitormattos added the bug Something isn't working label May 7, 2025
@vitormattos vitormattos changed the title [BUG]When browser is in French language, requesting a code doesn't work. When browser is in French language, requesting a code doesn't work. May 7, 2025
@vitormattos vitormattos added backend Backend task frontend Frontend task labels May 7, 2025
@vitormattos vitormattos self-assigned this May 7, 2025
@github-project-automation github-project-automation bot moved this from 0. Needs triage to 4. to release in Roadmap May 9, 2025
@Olybo
Copy link
Author

Olybo commented May 15, 2025

Hello @vitormattos,
Thanks a lot for this fix.

Do you know when you will be able to deploy the fix as a new update available in Nextcloud ?

Because I do not want to make any pressure on you and your team, do you have a procedure so I can implement the fix myself in my Nextcloud instance ?

Thank you very much.

@vitormattos
Copy link
Member

Today 🥳

@vitormattos vitormattos reopened this May 16, 2025
@github-project-automation github-project-automation bot moved this from 4. to release to 1. to do in Roadmap May 16, 2025
@vitormattos
Copy link
Member

I will maintain this issue as opened until we have the newest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend task bug Something isn't working frontend Frontend task
Projects
Status: 1. to do
Development

Successfully merging a pull request may close this issue.

2 participants