Skip to content

SX126x : Missing security on casting symbTimeout in RadioSetRxConfig #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Martdur opened this issue Apr 3, 2025 · 0 comments
Open

SX126x : Missing security on casting symbTimeout in RadioSetRxConfig #1637

Martdur opened this issue Apr 3, 2025 · 0 comments

Comments

@Martdur
Copy link

Martdur commented Apr 3, 2025

Observation

In RadioSetRxConfig there is no security on casting uint16_t symbTimeout to uint_8t in SX126xSetLoRaSymbNumTimeout.

Impact

Leading to Rx2 timeout issues due to wrong Rx window value.

symbTimeout should be lower than uint8_t limitation otherwise it'll trigger wrong timeout irq.

This can happens when using high data rate with a high MAX_RX_TIMEOUT_ERROR.

Recommendation

Add a security in the choice of MAX_RX_TIMEOUT_ERROR or in the definition of Rxearly Rxlate and RxWindowTimeout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Martdur