Skip to content

Commit b6be458

Browse files
Replaced inline flash message checks with reusable expect_flash command
1 parent dfc52a8 commit b6be458

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

cypress/e2e/ui/Settings/Application-Settings/edit_collect_logs.cy.js

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -165,9 +165,8 @@ function resetProtocolDropdown({
165165
cy.get('#diagnostics_collect_logs .bx--btn-set button[type="Submit"]')
166166
.contains(saveButton)
167167
.click();
168-
cy.get('#main_div #flash_msg_div .alert-success').contains(
169-
'Log Depot Settings were saved'
170-
);
168+
// Validating confirmation flash message
169+
cy.expect_flash(flashTypeSuccess, flashMessageSettingsSaved);
171170
}
172171
}
173172
);
@@ -179,10 +178,8 @@ function cancelButtonValidation() {
179178
.contains(cancelButton)
180179
.should('be.enabled')
181180
.click();
182-
// Validating confirmation alert text displayed
183-
cy.get('#main_div #flash_msg_div .alert-success').contains(
184-
'Edit Log Depot settings was cancelled by the user'
185-
);
181+
// Validating confirmation flash message
182+
cy.expect_flash(flashTypeSuccess, flashMessageOperationCanceled);
186183
}
187184

188185
function resetButtonValidation() {
@@ -220,10 +217,8 @@ function saveButtonValidation() {
220217
.contains(saveButton)
221218
.should('be.enabled')
222219
.click();
223-
// Validating confirmation alert text displayed
224-
cy.get('#main_div #flash_msg_div .alert-success').contains(
225-
'Log Depot Settings were saved'
226-
);
220+
// Validating confirmation flash message
221+
cy.expect_flash(flashTypeSuccess, flashMessageSettingsSaved);
227222
}
228223

229224
describe('Automate Collect logs Edit form operations', () => {

0 commit comments

Comments
 (0)