MaxWorkers in throttled background message processor is not respected #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miquelbeltran
previously approved these changes
May 23, 2025
added 2 commits
May 28, 2025 22:46
miquelbeltran
approved these changes
May 30, 2025
Comment on lines
+726
to
+732
| [Test] | ||
| public void ThrottledBackgroundMessageProcessor_VerifyBugCondition_DirectCheck() | ||
| { | ||
| // This test was designed to diagnose the bug condition | ||
| // Since the bug is now fixed, this test is no longer needed | ||
| Assert.Pass("Bug has been fixed - this diagnostic test is no longer applicable"); | ||
| } |
There was a problem hiding this comment.
Not sure if there is an agreement to leave this in place, but I think it could be removed if the test is no longer necessary.
There was a problem hiding this comment.
Haha yeah. Just waiting on feedback from customer. If it’s all good I’ll cleanup the tests a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #568