Skip to content

Support Copying Attributes as References #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robyngit opened this issue Mar 26, 2025 · 0 comments · May be fixed by #2687
Open

Support Copying Attributes as References #2652

robyngit opened this issue Mar 26, 2025 · 0 comments · May be fixed by #2687
Labels
ADC CI-09 Enhanced data submission tools & portals (ADC deliverable) arctic data center attribute editor redesign New attribute section in the metadata editor editor enhancement
Milestone

Comments

@robyngit
Copy link
Member

Extend the attribute copying functionality (feature #688) to allow creating a reference (linking to an existing attribute list) in addition to cloning attributes (copying without any linkage) - the current method. See that the EML attributeList allows references: docs.

This would be useful if: a user has multiple entities within the same data package that share exactly the same attribute structure. If they update the attributes in one entity, they may want those changes to automatically reflect in all linked entities. For example, a dataset split into multiple entities (e.g., yearly measurements) that share an identical schema. If they find a typo in one attribute name, fixing it once updates all linked entities. Especially important for data packages with 100s + files.

The UI should provide a clear option for copying as a reference, and should make it obvious when the attributeList for one entity is a reference to an attributeList from another entity. We will need to add support for parsing and serializing references in attributeLists.

@robyngit robyngit added ADC CI-09 Enhanced data submission tools & portals (ADC deliverable) arctic data center editor enhancement labels Mar 26, 2025
@robyngit robyngit added this to the 2.34.0 milestone Apr 10, 2025
@robyngit robyngit moved this to Ready in MetacatUI Apr 23, 2025
@robyngit robyngit moved this from Ready to In Review in MetacatUI Apr 23, 2025
@robyngit robyngit moved this from In Review to Ready in MetacatUI Apr 23, 2025
@robyngit robyngit moved this from Ready to In Review in MetacatUI Apr 23, 2025
@robyngit robyngit moved this from In Review to In Progress in MetacatUI Apr 23, 2025
robyngit added a commit that referenced this issue Apr 28, 2025
- Including tests for both

Issue #2652
robyngit added a commit that referenced this issue May 6, 2025
robyngit added a commit that referenced this issue May 8, 2025
robyngit added a commit that referenced this issue May 13, 2025
- Since an attributeList cannot have both attrs and refs, make sure that the references are deleted when attrs are added to the list.
- Ensure UI re-renders when references get removed

Issue #2652
robyngit added a commit that referenced this issue May 15, 2025
- Add option to copyAttributeList to copy attributes as a linked reference
- Added EMLUtilities file to store common EML functions, like getParentEML
- Made sure that parentModel is passed down the line of sub-models correctly in eml attribute related models/collections
- Fixed logic with listeners

Issue #2652
robyngit added a commit that referenced this issue May 19, 2025
- Fix bug that occurs when a entity view needs to be created for an existing dataone object with no matching eml entity. The view was not being created and an error was thrown.
- Fix a bug introduced in development of #2652 that prevented the dataONEobject ID from being added to the EML entity

Issue #2652
robyngit added a commit that referenced this issue May 19, 2025
Allows switching between two options.
Uses a button group (aka segmented control) to indicate the selection more clearly than a classic switch toggle or checkbox.
Allows adding a description for both options.

Issue #2652
robyngit added a commit that referenced this issue May 19, 2025
@robyngit robyngit linked a pull request May 19, 2025 that will close this issue
@robyngit robyngit moved this from In Progress to In Review in MetacatUI May 19, 2025
@robyngit robyngit added the attribute editor redesign New attribute section in the metadata editor label May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADC CI-09 Enhanced data submission tools & portals (ADC deliverable) arctic data center attribute editor redesign New attribute section in the metadata editor editor enhancement
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

1 participant