-
Notifications
You must be signed in to change notification settings - Fork 256
How to get the unitary matrix of a given kernel #1822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Tentatively moving this to 0.9 for tracking, but this is not yet confirmed as planned. |
+1 for this since we need it for a collaboration, thanks. |
I would make a few suggestions for this in the interest of performance. To get the unitary we have to do tensor contraction, and it gets expensive real fast as we increase the entanglement. With that being said, I would suggest using sth like Dr. Nguyen mentioned these have to be accessible in C++, so I'll have a look for any alternatives for this in C++. Ohh, and one thing. It would be great if you don't do this as we add gates. Some packages (I believe qiskit) do this which adds alot of overhead for deep circuits. I imagine it would be better to contract it at the end if the user wants a unitary matrix of the overall circuit. This also makes it easier to use JIT, or GPU-acceleration for performing this. |
Greetings there, Hope all are well. May I ask if there's an expected timeline for when this feature will be done? |
You can use this hack in the meantime if it helps:
|
@zohimchandani Thank you! |
A bit of an unrelated question, sorry (too small to open a ticket for). How can I pass a list of qubits here? It doesn't let me slice nor pass in a list: # Create a `Kernel` that accepts a qubit as an argument.
# Apply an X-gate on that qubit.
target_kernel, qubit = cudaq.make_kernel(cudaq.qubit)
target_kernel.tdg(qubit)
# Create another `Kernel` that will apply `target_kernel`
# as a controlled operation.
kernel = cudaq.make_kernel()
qubits = kernel.qalloc(3)
# In this case, `control` performs the equivalent of a
# controlled-X gate between `control_qubit` and `target_qubit`.
kernel.control(target_kernel, qubits[:2], qubits[2])
print(cudaq.draw(kernel)) I want to add a controlled Tdg gate, with qubits 0 and 1 being the control indices, and qubit 2 being the target. |
See this for an example and let us know if that helps. It is recommended that you switch to the new way of creating kernels with the |
Ohh I have read that. I am wrapping |
Maybe the better question is how to do I'd really appreciate some help in making the UI similar to what Qiskit, Cirq, or TKET have. This is more like Pennylane, which is what I'm trying to avoid. I'm not really comfortable with using decorated functions to represent circuits. Makes it really hard to wrap and use externally like I am. |
|
Right, but then you'll get stuck with On a more related note, I was wondering how I could get the unitary of a circuit when using the syntax you showed (the one I use hehe). Essentially when you define a circuit import cudaq
n_qubits = 2
kernel = cudaq.make_kernel()
qubits = kernel.qalloc(n_qubits)
kernel.h(qubits[0])
kernel.cx(qubits[0], qubits[1]) How to get this one's unitary? |
- Added native decomposition for multi-controlled gates with `qickit/synthesis/gate_decompositions/multi_controlled_gate_decomposition` module using CX, U3, and Global Phase. - Updated `qickit.circuit` subclasses to avoid recreation of mapping dictionary on every method call. - Added `qickit.circuit.from_framework` module for creating `qickit.circuit.Circuit` instances from other supported frameworks. - Moved `circuit.from_cirq()`, `circuit.from_qiskit()`, `circuit.from_tket()`, `circuit.from_quimb()`, and `circuit.from_qasm()` to `qickit.circuit.from_framework` module, and only wrapped them within `qickit.circuit.Circuit` using said functions as shortcut. - Improved the polymorphic implementation of `qickit.circuit` subclasses with `circuit._gate_mapping()` in contrast to the prior scattered implementation. - Deprecated `circuit.clbit_condition()` as it will be re-implemented using control flow manager in future commits properly. - Added transpile calls to `qickit.backend.AerBackend` for using AerSimulator due to Qiskit/qiskit#13162. - Removed `cudaq` from dependencies for the moment until NVIDIA/cuda-quantum#1822 is resolved. - Removed `qiskit-aer-gpu` dependency for compatibility for users without GPU. - Updated stubs to reflect the differences. - Added additional testers. - Suppressed testers for `qickit.synthesis.unitarypreparation.Diffusion` due to long runtime when pushed to github.
Was this not included in the 0.9.0 release? I think this feature would be nice, happy to work on it as well @bettinaheim |
It wasn't. I'd really want to see this ASAP too. |
Apologies for the incorrect labeling. Unfortunately, we needed to defer it. @arulandu It would be great if you want to work on it! |
Greetings, Hope all are well. May I ask if there has been any progress on this task? |
I can work on this, but would it be possible to use quimb? Makes it easier to finish the work, and is more efficient than any manual approach given the significant optimizations quimb provides, i.e., optimal path contraction. |
Shall I add this? I have done something similar for |
Hi @ACE07-Sev - thanks for your interest in the issue. Generally, we try to avoid external dependencies unless the benefits significantly outweigh the cost (integration, maintenance, testing, etc.). Check out the |
Right, but the point I was trying to make is that quimb takes care of the simulation (aka tensor contraction) given its high-level api, whereas if we do c++ we'd have to re-implement the whole thing from scratch and would not have the advantages that come from quimb, aka optimal path contraction, caching (huge time saver), and approximate tensor network representations (MPS/MPO save alot of time in simulation especially beyond 20 qubits or so). |
The simulation part should be handled for you by the |
This issue is still open and up for grabs for Unitary Hack. |
I've opened a draft with initial implementation of the feature. It should work with any 1-qubit gate but not with multiqubit gates as for now |
Uh oh!
There was an error while loading. Please reload this page.
Original Request
Greetings there,
Hope all are well. I would like to know how I can get the unitary matrix of a circuit in cudaq. I've seen
.sample()
and.get_state()
for counts and statevector definitions, but haven't been able to find the unitary matrix definition. Thanks in advance!Unitary Hack Instructions
Description
Define and implement a new API in CUDA-Q to get the unitary matrix of a kernel.
This API returns the matrix representing the unitary of the execution path, i.e., the trace, of the provided kernel.
C++:
which returns a
complex_matrix
representation of the unitary.Python:
cudaq.get_unitary(kernel, *args) -> numpy.ndarray
which returns
numpy
2D array.Details
CUDA-Q has a "tracer" mode which is used by the
draw
API.cuda-quantum/runtime/cudaq/algorithms/draw.h
Lines 28 to 31 in dcb0aba
This returns a list of instructions (gate name, target qubit ids, control qubit ids, and parameters) in an execution path of the kernel.
cuda-quantum/runtime/common/ExecutionContext.h
Lines 84 to 86 in c53f774
Use this list to compute the unitary matrix for that kernel.
The matrix for each gate can be retrieved with
nvqir::getGateByName
.cuda-quantum/runtime/nvqir/Gates.h
Lines 50 to 54 in dcb0aba
Using third-party libraries is acceptable, as long as CUDA-Q already uses them. No new dependencies.
Anything that the
tracer
doesn't support is not expected to be handled. In other words, if one can usedraw
API on a kernel successfully, then one should be able to useget_unitary
on it.The text was updated successfully, but these errors were encountered: