Skip to content

Commit c80356d

Browse files
authored
Merge pull request #14 from Novartis/bugfix/issue_13
Negate filtering for failing.quartile.filter during deseq.dataset construction
2 parents 98dc8cd + ab6760a commit c80356d

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

pisces/R/make_expression_matrix.R

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -269,8 +269,13 @@ Summarize <- function(txi, tx2gene, annotation, args, metadata, species) {
269269
"genes."))
270270
ribo.genes <- which(grepl("^RP[SL]", scaled_df[, "symbol"], ignore.case = T))
271271

272-
first_quartile <- function(x) { y <- quantile(x, c(0.25, 0.5, 0.75), type=1)
273-
return(y[[1]])
272+
273+
274+
first_quartile <- function(x) {
275+
# > first_quartile(c(0,0,0,0,0,0,0,1,10,10))
276+
# [1] 1
277+
y <- quantile(x, c(0.25, 0.5, 0.75), type=1)
278+
return(y[[3]])
274279
}
275280

276281
message(paste("Excluding", length(ribo.genes), "ribosomal genes from TMM scaling factor calulation."))
@@ -389,7 +394,7 @@ deseq_analysis <- function(contrasts, txi.gene, contrast.metadata, formula, fail
389394
} else {
390395
deseq.dataset <- DESeqDataSetFromTximport(txi.gene, contrast.metadata, as.formula(paste0("~", contrasts$Factor[1])))}
391396
message(paste("Filtering", length(failing.quartile.filter), "genes failing --quartile-expression cutoff from DESeq2 dataset."))
392-
deseq.dataset <- deseq.dataset[failing.quartile.filter,]
397+
deseq.dataset <- deseq.dataset[-failing.quartile.filter,]
393398
message("Running DESeq2...")
394399

395400
deseq.dataset <- DESeq(deseq.dataset)

0 commit comments

Comments
 (0)