Skip to content

Bug: Incorrect Return Type Annotation in ParameterManager #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Imama-Kainat opened this issue Mar 28, 2025 · 1 comment
Open

Bug: Incorrect Return Type Annotation in ParameterManager #212

Imama-Kainat opened this issue Mar 28, 2025 · 1 comment

Comments

@Imama-Kainat
Copy link

In the ParameterManager class (located in src/workflow/ParameterManager.py), the method get_parameters_from_json is currently annotated with a return type of None, even though it always returns a dictionary.

Current Signature:

def get_parameters_from_json(self) -> None:
This was referenced Mar 28, 2025
Closed
Merged
@ZenMachina16
Copy link
Contributor

Hi, I've opened pr #221 to fix the issue by updating the return type of get_parameters_from_json from None to dict. Please review the changes. Thanks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Imama-Kainat @ZenMachina16