Skip to content

Commit d144f0c

Browse files
author
Ludwig Friedmann
authored
Merge pull request #267 from OpenSimulationInterface/Moving-Objects-relative-velocity-definition
Update Definition solves #234
2 parents 9c9756c + b5bd541 commit d144f0c

File tree

3 files changed

+19
-10
lines changed

3 files changed

+19
-10
lines changed

osi_common.proto

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,8 @@ message BaseStationary
272272
optional Vector3d position = 2;
273273

274274
// The relative orientation of the stationary object w.r.t. its parent
275-
// frame.
275+
// frame, noted in the parent frame. The orientation becomes global/absolute
276+
// if the parent frame is inertial (all parent frames up to ground truth).
276277
//
277278
// <tt>Origin_base_stationary_entity :=
278279
// Rotation_yaw_pitch_roll(#orientation)*(Origin_parent_coordinate_system -
@@ -327,7 +328,9 @@ message BaseMoving
327328
//
328329
optional Vector3d position = 2;
329330

330-
// The relative orientation of the moving object w.r.t. its parent frame.
331+
// The relative orientation of the moving object w.r.t. its parent frame,
332+
// noted in the parent frame. The orientation becomes global/absolute if
333+
// the parent frame is inertial (all parent frames up to ground truth).
331334
//
332335
// <tt>Origin_base_moving_entity :=
333336
// Rotation_yaw_pitch_roll(#orientation)*(Origin_parent_coordinate_system -
@@ -338,18 +341,17 @@ message BaseMoving
338341
//
339342
optional Orientation3d orientation = 3;
340343

341-
// The relative velocity of the moving object w.r.t. its parent frame and
342-
// parent velocity.
343-
// The velocity becomes global/absolute if the parent frame does not move.
344+
// The relative velocity of the moving object w.r.t. the parent frame,
345+
// noted in the parent frame. The velocity becomes global/absolute if
346+
// the parent frame does is inertial (all parent frames up to ground truth).
344347
//
345348
// <tt>#position (t) := #position (t-dt)+ #velocity *dt</tt>
346349
//
347350
optional Vector3d velocity = 4;
348351

349-
// The relative acceleration of the moving object w.r.t. its parent frame
350-
// and parent acceleration.
351-
// The acceleration becomes global/absolute if the parent frame is not
352-
// accelerating.
352+
// The relative acceleration of the moving object w.r.t. its parent frame,
353+
// noted in the parent frame. The acceleration becomes global/absolute if
354+
// the parent frame is inertial (all parent frames up to ground truth).
353355
//
354356
// <tt> #position (t) := #position (t-dt)+ #velocity *dt+ #acceleration
355357
// /2*dt^2</tt>
@@ -360,7 +362,9 @@ message BaseMoving
360362

361363
// The relative orientation rate of the moving object w.r.t. its parent
362364
// frame and parent orientation rate in the center point of the bounding box
363-
// (origin of the bounding box frame).
365+
// (origin of the bounding box frame), noted in the parent frame.
366+
// The orientation becomes global/absolute if the parent frame is inertial
367+
// (all parent frames up to ground truth).
364368
//
365369
// <tt>Rotation_yaw_pitch_roll(#orientation (t)) :=
366370
// Rotation_yaw_pitch_roll(#orientation_rate

osi_detectedobject.proto

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,13 +151,16 @@ message DetectedMovingObject
151151
// The base parameters of the moving object.
152152
//
153153
// \note The bounding box does NOT includes mirrors for vehicles.
154+
// \note The parent frame of \c base is the sensor's vehicle frame.
154155
//
155156
optional BaseMoving base = 2;
156157

157158
// The root mean squared error of the base parameters of the detected
158159
// moving object (e.g. car). \c MovingObject::base has to be
159160
// identical for all \c #candidate moving objects.
160161
//
162+
// \note The parent frame of \c base is the sensor's vehicle frame.
163+
//
161164
optional BaseMoving base_rmse = 3;
162165

163166
// Reference point location specification of the sensor measurement

osi_sensordata.proto

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ message SensorData
135135
// \note This value is only set by sensors that are able to
136136
// provide an own estimation of the host vehicle location.
137137
// \note Note that dimension and base_polygon need not be set.
138+
// \note The parent frame of \c host_vehicle_location is the sensor frame.
138139
//
139140
optional BaseMoving host_vehicle_location = 3;
140141

@@ -143,6 +144,7 @@ message SensorData
143144
// \note This value is only set by sensors that are able to
144145
// provide an own estimation of the host vehicle location.
145146
// \note Note that dimension and base_polygon need not be set.
147+
// \note The parent frame of \c host_vehicle_location_rmse is the sensor frame.
146148
//
147149
optional BaseMoving host_vehicle_location_rmse = 4;
148150

0 commit comments

Comments
 (0)