Skip to content

Two fields added in SensorViewConfiguration for Radar and Lidar. #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

PhRosenberger
Copy link
Contributor

@PhRosenberger PhRosenberger commented May 15, 2020

Reference to a related issue in the repository

Solves #389.

Description

This PR is an extension of OSI with two fields added in SensorViewConfiguration for Radar and Lidar to properly configure a ray tracer. One is max_range_per_ray in m that terminates a ray if nothing is hit, the other is max_range_per_pixel in m that is applied to the sum of the lengths of all rays on one path that terminates the ray propagation in case of multi-path-propagation.

Mention a member

@pmai, Please check this extension.

Check the checklist

  • My code and comments follow the style guidelines and contributors guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

@PhRosenberger PhRosenberger requested a review from pmai May 15, 2020 08:44
@PhRosenberger PhRosenberger changed the title Two fields added in SensorViewConfiguration for Radar and Lidar. solv… Two fields added in SensorViewConfiguration for Radar and Lidar. May 15, 2020
@clemenshabedank clemenshabedank added this to the V4.0.0 milestone May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing fields for ray tracer config in radar and lidar sensor view config
3 participants