Skip to content

Add ERC6372 to VotesComponent #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ericnordelo opened this issue Dec 2, 2024 · 3 comments · May be fixed by #1417
Open

Add ERC6372 to VotesComponent #1242

ericnordelo opened this issue Dec 2, 2024 · 3 comments · May be fixed by #1417
Assignees
@immrsd
Labels
ERC6372 support
Milestone
1. current

Comments

@ericnordelo
Copy link
Member

Support ERC6372 for Votes tokens, to make it possible to use block numbers for tracking checkpoints instead of timestamps.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Contracts for Cairo Dec 2, 2024
@DarkLord017
Copy link

Hi @ericnordelo can i work on this ?

@ericnordelo
Copy link
Member Author

Hey @DarkLord017, thanks for your interest in contributing to the library. This specific issue is big, since it involves design around the Governor module to make it compatible with block number timepoints. Because of this, we have plans to work on it ourselves, and we don't see it as a good first issue.

@DarkLord017
Copy link

Okay ! Thank you for your response 😊

@ericnordelo ericnordelo modified the milestones: 2. next, 1. current Mar 19, 2025
@immrsd immrsd self-assigned this Mar 26, 2025
@immrsd immrsd moved this from 📋 Backlog to 🏗 In progress in Contracts for Cairo Mar 31, 2025
@immrsd immrsd linked a pull request Apr 22, 2025 that will close this issue
Open
@ericnordelo ericnordelo moved this from 🏗 In progress to 👀 In review in Contracts for Cairo Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@immrsd immrsd

Labels
ERC6372 support
Projects
Contracts for Cairo
Status: 👀 In review
Milestone
1. current
Development

Successfully merging a pull request may close this issue.

Contract Clock for Votes immrsd/cairo-contracts
3 participants
@ericnordelo @immrsd @DarkLord017