Skip to content

Incorrect Max hit taken calculation with Mind over Matter, Eldritch Battery, and Corrupted Soul #6797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
3 tasks done
Mugsy13ms opened this issue Oct 8, 2023 · 0 comments · May be fixed by #6869 or #8590
Open
3 tasks done

Incorrect Max hit taken calculation with Mind over Matter, Eldritch Battery, and Corrupted Soul #6797

Mugsy13ms opened this issue Oct 8, 2023 · 0 comments · May be fixed by #6869 or #8590
Labels
bug: calculation Numerical differences

Comments

@Mugsy13ms
Copy link

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

Check for support

  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What is the value from the calculation in-game?

When you have Mind over Matter, Eldritch Battery, and Corrupted Soul with excess Energy Shield and most of your mana reserved then the damage will be split between 60% health, 20% Energy Shield, and 20% Mana. The issue is these values are unlikely to match exactly and you may have not enough mana to take the 20% damage

What is the value from the calculation in Path of Building?

When you have Mind over Matter, Eldritch Battery, and Corrupted Soul with excess Energy Shield and most of your mana reserved then the Max Hit Calculation will be incorrect. If you mouse over the maximum hit on the calculation tab then you will see the life remaining will actually be negative. This applies to physical max hit and all the elements but not chaos since it bypasses energy shield. It is probably a result of all the calculations about where the damage is going while having more than enough energy shield and not enough mana for the hit.

How to reproduce the issue

  1. Make a new character
  2. Allocate Mind over Matter, Eldritch Battery, and Corrupted Soul (via Glorious Vanity or Replica Soul Tether).
  3. Add Discipline level 20 to make sure you have more energy shield than required for max hit
  4. Add Determination (or another skill gem) to reserve most of your mana
  5. Check the max hit taken under calculations for physical or elemental (not chaos)

Character build code

eNqtW1132jgTvm5-hQ9X7Tkk-JOPnGT3EJI07JKWQtLuvjd7hC1AW9mitkzC7tn__o4kGxyKHTumFw1YM49mRqPRzMhc_PrsU22Nw4iw4LJhnOkNDQcu80iwuGw8Ptyedhu__nJyMUZ8-Xl-FRMqRn45eXchP2sUrzG9bJhOQ-MoXGD-NYWy_gKoFQr4ErPgHv3Nwo_Mu2x8YgFuaDMUeISn31yKougT8vFlY-oCc0NDkYsDb7B7nhAuUYhcjsORmLYfc3bPPBjlYQyjPiLBlLnfMf8YsngF2jS0NcFPimZ4P_48eciIRIKsSKDSu4sxRRscTjniWgT_XTb6YBm0wHeEAxSiMeDojVYh7VUcRvwa-fDxdZ7pCmPvdbJxiG_mc-xyssaDkPDBEgVuCfiqtPcx5WRFCQ639MaZk8dx9xO4oefCPzCO6PV4-rogipKVsPg3wpdXFCxYCldQDxcB4bg0-ZiRiAWVpC5FPIgphW1UinaCIxyuESclBRkwf0aCkjYZMEY99hRklts0jVwPDzH6PFeeOEEeiaN7zEMcbbmds14e7z0K0IBFJVZVUI5xCAGAV2KYYpdBzKg6R0XOEZnj8pSV9EgYqkrzNj1upmXpKgO_TaAJBMxylFMW05KUfBfITCd_h_3IEhpOLuU1ft7h5c46DHaiGb2Cjf3jBWXRtGvG5blYKgrd3I23lHavbZ_ZtmXZvY5jdXIPmOUmIi6i9-iZ-LEPkf0Bfce7CXudXr4LLpY8gGiWx2sbueLekhDnsVmdTn7Uot5b2JaIRXl8pmMWbbIdftssOMzdc0E8DNxyW_cxCGV0z-QABfiCYwI7SuQZM4rLsuwmSTZmmeNazbXAQTLhZsvUOSucbYSxu_wImdgEcVwuEO_WIN_LpG0FcSnbCsIDtrWNcgw_2ck-a_ccy9Yd3ej0zCKQwzZrn3WLmCra7CbA4WIzXRJMM37TscvQp6IN0KoMqzR7lr-U-V9OeMggpVgrmuUbCr1yx0xVmdYoykZfo11sLkVezlExpK_A4OGyafo4ZH-LQoBWY-uHPot3Z5ylO8VKKPpSOqRnh6p5JtiL3ReHVf4JeEWhWiurAYhFaSWOPufI_X7NvAWuNEl1jmm8WkHwEMtelk8cfZDak0wac9ouQf0ZfDa7efWiQ7L8BDvq0hNsD_79WexOSZbyuoiTu4IyO_LSU2zr63uICj5Ef1ma37NdSMk9PG6hmitVbUnCkiXimD2B5EvRU4mqUUOGs9vnuaKEOPhnUxr_BXmpCW4CLw7FVig9xz7HoWkeiA8RM4quEUeal6TFX1FIUMBN2fCJMArd5QiW_hZROoMAcNnIPhXf9hiNdG0vWrKpJT4N_RULuYafxZ8xCvnmsjFHNMKKUD4BnIiTQJbmEG0obWjTJXvqe2uhxQOU1lHKpKHVCgfeC4yHEGMNSZ8TIVcIIXUUX7INsKEnjKb5KOJwXCk_jYQaAQMBICGzut2m1evaRtMyOrrVNDu24TQhXel1m0YPcpam0-1aVtPumI7RhIpAh1HL7vSaZrtj603L7Bjwf1e3u8221eu0m47Zazdtw2wDU7fTEY9tu9O0baNrN612G57Y8Ehv2manDayWBQBOW-84Tcfp6QAAtQbwWu1O09Dtnt5s6yBh0-q0O7BGHDTP9AlNM2kBKk2FEd5dPE5G8sO7Jeer6LzVenp6OlshvmRz_Ayn35nL_NYKmMB8p9F3QumpgG314d_Vot-_m_zj-u3bjmFGfywffrsfzcjDk_tt8Gwu9XkXPbJxwG5Hg-Wo0_6918ORP-x95F-mwWA4xObTGv3Jl59uvnTZabyOv29cQL28lIK1UskuVK8xUmIm3-SiCD2k9Roa4dgXX5PgAexZrgsRnkICy6jcuyXWXjqicA7x4RPjWNKKh-mXi6nQN9Ii8M2P2I-uNhBSbkXKtNf-SbxLUE8xV_sjy5N2Tj08RzEVz7_EiBLh7Hr26Uh1eQMW-tsaEaDA2cXJpxAfNivhjf3RSI30KU_AxHSp5ysPTwTSiJd6ffJQ9nD7O6kHiLqRlJsELo3BtEESbUEaAhuOopmQTDStRU3kZXvBGZztNO8uQJqE-CNlM0TNlCVtZeuNF-NGOi6dTKzlNYlc0SUVHekfSkX5WJmroS3Ukt9jjjyIU60h-EDUElZoSWHg0wEIafI9LVwWB2rZAuQnUSLD2jqeShhii5_EsrdrdRCltGIvuLfbRWAnmyNxG7lB1BYQH6WPSIphsIq5RLxs-GCmv2bxfC66_6ApD-WNxs3t7c3gYfj1JjlQsizSGn8FsT8T_W_1d3fsT7FMa7UonkXq42XjK8FPUhCQHREaCcUoRasIb0O99PFEcgp8BWiS6o5sLw8OY-0I8pFunnEIJ9MCSiI3JDhXru34K0KpCUW5JA7gPDTRs88HUtn4AE4xVc7lWEpeiOSjiFuKXHXEYAEvnOmI5s6cjL5iCS6iHLgrmRNX5C7FSy5ioqIqsIvrQtrjbgrWO6kp8jHkJUgegBrMZ1aXHHncyWiBVeWVSq5V1Wg--zV2Ua7uajCfedshYIG8ojuMsqUqQPrEAunksGn6hIr8P3dlbyjekuQDfuZLHCbJWh7SPcSolKRw44RkFvP8bZyhKLCV7GLmWEiM5bOqJl2ODmKsIBK96FXlGDRLkw-l-ju5gayIVdWCufZLKsuCJUi6JznmV6MFRkgbSDn6J8MFm0TG3_6aEU91F3K2yx5ZUcCALLQ-jOyU1IfZ76HUR7yFcuJ77nono_nsj5yIzOUAikpfSoGITVUPQeytegiT_URixzspTiFk_ILkD4OhCwPYlqZgfXkcXMMhxwvWtiSUFOvwRtipVglLhfKDmlZGVA6aXCwV-bAieQUIzqK7gmynHNK2r3WHERVvNDBaD_CnC7RaejIeocC7Fg35moqKfn68ArBUss-H0tXdku6jXrTSQkJ2ZkRqn7SNpjwUFeY_jPl_QmHvtNXnpCi2kkIY0rxrAsYOpZOkMwnCPy4bp8mt0YWsmpK6XHxOy_I4wuqy_BtGKxbIx6LAVUUKEGpr1axSxfCubp7AY7451x4_Db883pxAgRcSFkfaVwSJ1-YkbZhpv-EnTE9GGC1ifK6N8AKMdpI0wM61axZugEF7P2BhGK849jRxy_5hR_EHmSEo6LT312QNtad2C6jLzPj_cLhaAsANFHEBotqfLObLD9r7cYg168wwzvQMcX8ZQ2jT3g99n4UcqPv-jIhl_HCiqiSYf0tsnEhLT_CPc83UT9SLJ6CCaBKejIhPBDVnghByeEpc2DPnmn7yb2Kxc-O_f0MULPC5fub8d4Vg13saCTT4q80oY57G5tp7Q9dPu7quf9AiBDURpPc7KlEeCqLESjtk81jIiXV3yNaxkNW67IDtYwGrNTwZqxZcJIZDuTQagiUfsOBHDHvB02YbyfYVIXpyB2kW-KcrS3sozCdCEk3Kc9kAgVLPTor_XArzVQrrVQr7VQrnVYr0Dk02Q7ZbVXS28vbzy5YXZVx2CMezx8lItnRlIwI28VocRWnzUE8FyWNQk2hGBZYrBqFX6882UQT7L2leOlUAMOX7_GYFfpm7aNYbtNSmT2i1P7X9FqAa6icY5hEwDivUPoJC7SMo9CaMQwrV9k7rCBYxj6VNFX-7w5Bj8lr2OLDZ2rUlMCsj1J7SOpb9nSM4g3GE7WEcQQ67oiccK8SYdXekfQQDVj8zDi69BBt6QL5_BadYZf6rZW7lUug6BrTqGtCsGQOqCeBtNNWrquPEKjmpg3A4Mji1EdrH2hfGsYJUdd-ub0e79lo6x3GqKsr3_ZhifoRQah0hIlk1N6Vdk984jv3ffNRWdlq7Msdb0rCaVnXqxuojLYt9rOBytMT8zTVYBb4JCRaVlvBwaDKPswZHOymOUTHab9OpqvHrn_FHSjac2oLUP-LaVYNB3eDx84SqaZS-ziL7wvJtFhbMySJ9Q9LFS0Y9HCbQOMD-JvnNaPp-Sif7I45D9C_fz84w5rJFZEHo57l8qXTKkXx7c_91mJzJUt9MyU2zmD77C9WUxylmSd4zZ5TKplzWEsWM22vYlKHdeV24fatZenpbkCzURWv_t9H_B9bjewI=

Screenshots

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug: calculation Numerical differences
Projects
Effective HP issues
Status: No status
Milestone
No milestone
1 participant
@Mugsy13ms