Skip to content

Commit 3ce8d68

Browse files
committed
Improve debugging output
Being able to see in the logs when a request has been made to an unimplemented handler is important. Furthermore, being able to access the deep SSH debug messaging is important when trying to diagnose subtle issues related to SFTP / SSH protocol.
1 parent bea4424 commit 3ce8d68

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

src/classes/SftpSessionHandler.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ export class SftpSessionHandler {
167167
*/
168168
// eslint-disable-next-line class-methods-use-this
169169
public writeHandler = (): void => {
170-
logger.verbose('Request: SFTP write file (SSH_FXP_WRITE)');
170+
logger.error('UNIMPLEMENTED Request: SFTP write file (SSH_FXP_WRITE)');
171171
};
172172

173173
/**
@@ -195,7 +195,7 @@ export class SftpSessionHandler {
195195
*/
196196
// eslint-disable-next-line class-methods-use-this
197197
public fsetStatHandler = (): void => {
198-
logger.verbose('Request: SFTP write open file statistics (SSH_FXP_FSETSTAT)');
198+
logger.error('UNIMPLEMENTED Request: SFTP write open file statistics (SSH_FXP_FSETSTAT)');
199199
};
200200

201201
/**
@@ -328,7 +328,7 @@ export class SftpSessionHandler {
328328
*/
329329
// eslint-disable-next-line class-methods-use-this
330330
public removeHandler = (): void => {
331-
logger.verbose('Request: SFTP remove file (SSH_FXP_REMOVE)');
331+
logger.error('UNIMPLEMENTED Request: SFTP remove file (SSH_FXP_REMOVE)');
332332
};
333333

334334
/**
@@ -339,7 +339,7 @@ export class SftpSessionHandler {
339339
*/
340340
// eslint-disable-next-line class-methods-use-this
341341
public rmDirHandler = (): void => {
342-
logger.verbose('Request: SFTP remove directory (SSH_FXP_RMDIR)');
342+
logger.error('UNIMPLEMENTED Request: SFTP remove directory (SSH_FXP_RMDIR)');
343343
};
344344

345345
/**
@@ -387,7 +387,7 @@ export class SftpSessionHandler {
387387
*/
388388
// eslint-disable-next-line class-methods-use-this
389389
public readLinkHandler = (): void => {
390-
logger.verbose('Request: SFTP read link (SSH_FXP_READLINK)');
390+
logger.error('UNIMPLEMENTED Request: SFTP read link (SSH_FXP_READLINK)');
391391
};
392392

393393
/**
@@ -398,7 +398,7 @@ export class SftpSessionHandler {
398398
*/
399399
// eslint-disable-next-line class-methods-use-this
400400
public setStatHandler = (): void => {
401-
logger.verbose('Request: SFTP set file attributes (SSH_FXP_SETSTAT)');
401+
logger.error('UNIMPLEMENTED Request: SFTP set file attributes (SSH_FXP_SETSTAT)');
402402
};
403403

404404
/**
@@ -409,7 +409,7 @@ export class SftpSessionHandler {
409409
*/
410410
// eslint-disable-next-line class-methods-use-this
411411
public mkDirHandler = (): void => {
412-
logger.verbose('Request: SFTP create directory (SSH_FXP_MKDIR)');
412+
logger.error('UNIMPLEMENTED Request: SFTP create directory (SSH_FXP_MKDIR)');
413413
};
414414

415415
/**
@@ -420,7 +420,7 @@ export class SftpSessionHandler {
420420
*/
421421
// eslint-disable-next-line class-methods-use-this
422422
public renameHandler = (): void => {
423-
logger.verbose('Request: SFTP file rename (SSH_FXP_RENAME)');
423+
logger.error('UNIMPLEMENTED Request: SFTP file rename (SSH_FXP_RENAME)');
424424
};
425425

426426
/**
@@ -431,7 +431,7 @@ export class SftpSessionHandler {
431431
*/
432432
// eslint-disable-next-line class-methods-use-this
433433
public symLinkHandler = (): void => {
434-
logger.verbose('Request: SFTP create symlink (SSH_FXP_SYMLINK)');
434+
logger.error('UNIMPLEMENTED Request: SFTP create symlink (SSH_FXP_SYMLINK)');
435435
};
436436

437437
private readonly genericStatHandler = (reqId: number, itemPath: Buffer): void => {

src/server.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ if (typeof process.env.SSH_HOST_KEY_PATH === 'string') {
1414

1515
const serverConfig: ServerConfig = {
1616
hostKeys,
17+
debug: (message) => logger.silly(message),
1718
};
1819

1920
const connectionListener = (client: Connection): void => {

0 commit comments

Comments
 (0)