Autodesk: Add new options to enable or disable the trace and the performance log in Hd

[erikaharrison-adsk]

Description of Change(s)

Add options to enable or disable tracing. And add another option to enable or disable the performance log in hd.
Tracing and performance log is valuable for profiling. But in a formal release, they will impact the performance. So we should add the ability to disable the two features.

By default, both features are still enabled.

Link to proposal (if applicable)

• N/A

Fixes Issue(s)

• N/A

Checklist

• I have created this PR based on the dev branch

• I have followed the coding conventions

• I have added unit tests that exercise this functionality (Reference:
  testing guidelines)

• I have verified that all unit tests pass with the proposed changes

• I have submitted a signed Contributor License Agreement (Reference:
  Contributor License Agreement instructions)

[jesschimein]

Filed as internal issue #USD-11029

(This is an automated message. See here for more information.)

[spiffmon]

We are very sympathetic to the desires for this change! We are fine with changing TRACE_DISABLE into TRACE_ENABLE for consistency. But (and this applies to the newly introduced directive for Hd, also) we are not OK with requiring the build system to define the directive in order for the feature to be activated.

So, can you change teh guards from #if defined(TRACE_ENABLE) to #if TRACE_ENABLE and add a block at the top like

#if !defined(TRACE_ENABLE)
    #define TRACE_ENABLE 1
#endif

Thank you!

[PierreWang]

We are very sympathetic to the desires for this change! We are fine with changing TRACE_DISABLE into TRACE_ENABLE for consistency. But (and this applies to the newly introduced directive for Hd, also) we are not OK with requiring the build system to define the directive in order for the feature to be activated.

So, can you change teh guards from #if defined(TRACE_ENABLE) to #if TRACE_ENABLE and add a block at the top like

#if !defined(TRACE_ENABLE)
    #define TRACE_ENABLE 1
#endif

Thank you!

Hi @spiffmon , thank you for your comments. For the HD_PERF_ENABLE, we also need to add the similar block, right? And I think we also need to remove the changes in build system?

[spiffmon]

I believe so, yes.