Skip to content

Commit 41c4286

Browse files
add RSE check
Signed-off-by: Laurynas Jagutis <[email protected]>
1 parent 2c97feb commit 41c4286

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

pyproject.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,8 @@ select = [
124124
"RET",
125125
"PIE",
126126
"SLF",
127-
"UP"
127+
"UP",
128+
"RSE"
128129
]
129130
# the rule is deprecated, https://docs.astral.sh/ruff/rules/non-pep604-isinstance/#deprecation
130131
ignore = ["UP038"]

src/power_grid_model/_core/data_handling.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def get_output_type(*, calculation_type: CalculationType, symmetric: bool) -> Da
3838
if calculation_type == CalculationType.short_circuit:
3939
return DatasetType.sc_output
4040

41-
raise NotImplementedError()
41+
raise NotImplementedError
4242

4343

4444
def prepare_input_view(input_data: SingleDataset) -> CConstDataset:

src/power_grid_model/validation/_rules.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ def none_match_comparison( # noqa: PLR0913
371371
_set_default_value(data=data, component=component, field=field, default_value=default_value_2)
372372
component_data = data[component]
373373
if not isinstance(component_data, np.ndarray):
374-
raise NotImplementedError() # TODO(mgovers): add support for columnar data
374+
raise NotImplementedError # TODO(mgovers): add support for columnar data
375375

376376
if isinstance(ref_value, tuple):
377377
ref = tuple(_eval_expression(component_data, v) for v in ref_value)
@@ -763,7 +763,7 @@ def all_finite(data: SingleDataset, exceptions: dict[ComponentType, list[str]] |
763763
errors = []
764764
for component, array in data.items():
765765
if not isinstance(array, np.ndarray):
766-
raise NotImplementedError() # TODO(mgovers): add support for columnar data
766+
raise NotImplementedError # TODO(mgovers): add support for columnar data
767767

768768
for field, (dtype, _) in array.dtype.fields.items():
769769
if not np.issubdtype(dtype, np.floating):

src/power_grid_model/validation/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def _update_component_data(
111111
if isinstance(input_data, np.ndarray) and isinstance(update_data, np.ndarray):
112112
return _update_component_array_data(component=component, input_data=input_data, update_data=update_data)
113113

114-
raise NotImplementedError() # TODO(mgovers): add support for columnar data
114+
raise NotImplementedError # TODO(mgovers): add support for columnar data
115115

116116

117117
def _update_component_array_data(component: ComponentType, input_data: SingleArray, update_data: SingleArray) -> None:

0 commit comments

Comments
 (0)