Twitcho warning log about missing Starlette and uvicorn packages

[hgdagon]

What actually happened?

This happens on import. The default is set to AiohttpAdapter and I'm not manually changing it to Starlette.

What did you expect to happen instead?

Starlette and uvicorn packages not being required.

Minimum reproducible example:

import twitchio

Steps to reproduce the problem

import twitchio

Additional logs:

No response

System and Environment information

3.0.1

[EvieePy]

This is by design. They are both completely optional packages. The warning log is emitted due to TwitchIO attempting to import the packages into a core part of the library as opposed to for a completely optional separate package.

[hgdagon]

That is actually where my confusion stems from. They are optional, but TwitchIO tries to load them immediately, without checking what the adapter is set to.

[EvieePy]

Correct as they are needed as part of the web package, which isn't optional, and thus will always be included, even when the Starlette Adapter isn't used or available. Keep in mind using an Adapter is completely optional and has an implementation that allows it to be changed while the bot is active.

The warning is simply letting you know that a specific part of the library will not work (E.g. anything involving Starlette) as it is not installed.

[EvieePy]

I can look at changing the wording in the warning message but I see no reason to remove it completely.

[EvieePy]

Just to clarify how/why this happens:

StarletteAdapter is part of the web package. The twitchio package imports web and web needs to import the contents of everything for you to use.

So when you import twitchio you are also importing web for use; twitchio.web etc.

Since the Starlette stuff is optional if we don't catch the import exception when Starlette is not available the whole of twitchio will fail.

As stated above the warning was just put in place after catching the exception to let the user know it won't work (even though it may appear available). Similar warnings can be found in other libraries, for example: https://github.com/Rapptz/discord.py/blob/a00510988a204517f4777f1231407de3db726ae5/discord/client.py#L318

I hope this clarifies.

[hgdagon]

Understood. I had not considered changing the adapter while the client/bot is running.